public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Safonov <dima@arista.com>
To: linux-kernel@vger.kernel.org
Cc: Dmitry Safonov <0x7f454c46@gmail.com>,
	Dmitry Safonov <dima@arista.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ingo Molnar <mingo@kernel.org>, Jiri Slaby <jslaby@suse.com>,
	Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Jeff Dike <jdike@addtoit.com>,
	Richard Weinberger <richard@nod.at>,
	linux-um@lists.infradead.org
Subject: [PATCHv2 35/50] um/sysrq: Remove needless variable sp
Date: Mon, 16 Mar 2020 14:39:01 +0000	[thread overview]
Message-ID: <20200316143916.195608-36-dima@arista.com> (raw)
In-Reply-To: <20200316143916.195608-1-dima@arista.com>

`sp' is a needless excercise here.

Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: linux-um@lists.infradead.org
Signed-off-by: Dmitry Safonov <dima@arista.com>
---
 arch/um/kernel/sysrq.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
index c71b5ef7ea8c..c831a1c2eb94 100644
--- a/arch/um/kernel/sysrq.c
+++ b/arch/um/kernel/sysrq.c
@@ -27,7 +27,6 @@ static const struct stacktrace_ops stackops = {
 
 void show_stack(struct task_struct *task, unsigned long *stack)
 {
-	unsigned long *sp = stack;
 	struct pt_regs *segv_regs = current->thread.segv_regs;
 	int i;
 
@@ -38,10 +37,9 @@ void show_stack(struct task_struct *task, unsigned long *stack)
 	}
 
 	if (!stack)
-		sp = get_stack_pointer(task, segv_regs);
+		stack = get_stack_pointer(task, segv_regs);
 
 	pr_info("Stack:\n");
-	stack = sp;
 	for (i = 0; i < 3 * STACKSLOTS_PER_LINE; i++) {
 		if (kstack_end(stack))
 			break;
-- 
2.25.1


  parent reply	other threads:[~2020-03-16 14:42 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200316143916.195608-1-dima@arista.com>
2020-03-16 14:38 ` [PATCHv2 01/50] kallsyms/printk: Add loglvl to print_ip_sym() Dmitry Safonov
2020-03-16 15:29   ` Joe Perches
2020-04-17 22:59     ` Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 02/50] alpha: Add show_stack_loglvl() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 03/50] arc: " Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 04/50] arm/asm: Add loglvl to c_backtrace() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 05/50] arm: Add loglvl to unwind_backtrace() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 06/50] arm: Add loglvl to dump_backtrace() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 07/50] arm: Wire up dump_backtrace_{entry,stm} Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 08/50] arm: Add show_stack_loglvl() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 09/50] arm64: Add loglvl to dump_backtrace() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 10/50] arm64: Add show_stack_loglvl() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 11/50] c6x: " Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 12/50] csky: " Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 13/50] h8300: " Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 14/50] hexagon: " Dmitry Safonov
2020-03-17 15:34   ` Brian Cain
2020-03-16 14:38 ` [PATCHv2 15/50] ia64: Pass log level as arg into ia64_do_show_stack() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 16/50] ia64: Add show_stack_loglvl() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 17/50] m68k: " Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 18/50] microblaze: Add loglvl to microblaze_unwind_inner() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 19/50] microblaze: Add loglvl to microblaze_unwind() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 20/50] microblaze: Add show_stack_loglvl() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 21/50] mips: " Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 22/50] nds32: " Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 23/50] nios2: " Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 24/50] openrisc: " Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 25/50] parisc: " Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 26/50] powerpc: " Dmitry Safonov
2020-03-19  4:03   ` Michael Ellerman
2020-03-16 14:38 ` [PATCHv2 27/50] riscv: " Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 28/50] s390: " Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 29/50] sh: Add loglvl to dump_mem() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 30/50] sh: Remove needless printk() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 31/50] sh: Add loglvl to printk_address() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 32/50] sh: Add loglvl to show_trace() Dmitry Safonov
2020-03-16 14:38 ` [PATCHv2 33/50] sh: Add show_stack_loglvl() Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 34/50] sparc: " Dmitry Safonov
2020-03-16 14:39 ` Dmitry Safonov [this message]
2020-03-16 14:39 ` [PATCHv2 36/50] um: " Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 37/50] unicore32: Remove unused pmode argument in c_backtrace() Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 38/50] unicore32: Add loglvl to c_backtrace() Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 39/50] unicore32: Add show_stack_loglvl() Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 40/50] x86: Add missing const qualifiers for log_lvl Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 41/50] x86: Add show_stack_loglvl() Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 42/50] xtensa: Add loglvl to show_trace() Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 43/50] xtensa: Add show_stack_loglvl() Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 44/50] sysrq: Use show_stack_loglvl() Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 45/50] x86/amd_gart: Print stacktrace for a leak with KERN_ERR Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 46/50] power: Use show_stack_loglvl() Dmitry Safonov
2020-03-18 12:54   ` Rafael J. Wysocki
2020-03-16 14:39 ` [PATCHv2 47/50] kdb: Don't play with console_loglevel Dmitry Safonov
2020-03-17  0:06   ` Doug Anderson
2020-03-17 16:00   ` Daniel Thompson
2020-03-16 14:39 ` [PATCHv2 48/50] sched: Print stack trace with KERN_INFO Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 49/50] kernel: Use show_stack_loglvl() Dmitry Safonov
2020-03-16 14:39 ` [PATCHv2 50/50] kernel: Rename show_stack_loglvl() => show_stack() Dmitry Safonov
2020-03-17  2:54   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200316143916.195608-36-dima@arista.com \
    --to=dima@arista.com \
    --cc=0x7f454c46@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jdike@addtoit.com \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=mingo@kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=pmladek@suse.com \
    --cc=richard@nod.at \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox