From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8289CC0044D for ; Mon, 16 Mar 2020 16:46:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BC9820719 for ; Mon, 16 Mar 2020 16:46:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Z+bUmJMa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732065AbgCPQqe (ORCPT ); Mon, 16 Mar 2020 12:46:34 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:55946 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731722AbgCPQqd (ORCPT ); Mon, 16 Mar 2020 12:46:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UldIcImfTlWsfuaRmvn6WjdH00Ncoz606zt/8JlydiE=; b=Z+bUmJMag1G3RqumhLOE1Q/vjz v9szg5QlQu8n0i5EUlQC8V9GhRoGksMR0LBbbhcrfvaVRNM7E4njQ4xLWgx1GtsBvnrVaeZMUI4T/ hQPHE9MzLhI9kkSFRqxyN6XH71BF9W8Wmkn7DStsz3IhPB+fKYOV5RjggnNWLtYn3ZMRCRA0B2Ty+ TKIrZfPWT0Yo9pcYXXTV0vre/fZKoAZKq6XsuokK6oZE67ELPvEOSjQ7qLcFs4+lNjRr/gUnT0Ueg XfcWFOriiF+vo6Z/P6lGMo56Z7pjnYUE1+Pe4MMnihFG3yB3xznCeg9PAOmwZ2riMPUdPUEn1cYJm bD4GPytw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDsso-0003Jc-R5; Mon, 16 Mar 2020 16:46:31 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 39F603045E0; Mon, 16 Mar 2020 17:46:28 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 1D9292B4CD481; Mon, 16 Mar 2020 17:46:28 +0100 (CET) Date: Mon, 16 Mar 2020 17:46:28 +0100 From: Peter Zijlstra To: Josh Poimboeuf Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [RFC][PATCH 15/16] objtool: Implement noinstr validation Message-ID: <20200316164628.GG12521@hirez.programming.kicks-ass.net> References: <20200312134107.700205216@infradead.org> <20200312135042.288201372@infradead.org> <20200315180320.cgy2ealklbjlx4g7@treble> <20200316132419.GF12521@hirez.programming.kicks-ass.net> <20200316161904.zouwkwup6vwsmxgp@treble> <20200316162147.xufxhddz5ztqq5q3@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316162147.xufxhddz5ztqq5q3@treble> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2020 at 11:21:47AM -0500, Josh Poimboeuf wrote: > On Mon, Mar 16, 2020 at 11:19:07AM -0500, Josh Poimboeuf wrote: > > > And I was hoping to get vmlinux.o objtool clean, surprisingly there > > > really aren't that many complaints. But the -i thing makes it run > > > significantly faster without duplicating all the bits we've already > > > checked. > > > > My suggestion is that the "-i" option would be hard-coded (for now). So > > nothing extra would get checked. > > If that wasn't clear, I mean that for vmlinux.o we'd only do the > instr-checking. For individual .o's we'd do everything else. That'd get in the way of making vmlinux.o objtool clean though :/