From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Mark Rutland <mark.rutland@arm.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the random tree
Date: Mon, 16 Mar 2020 16:59:23 +1100 [thread overview]
Message-ID: <20200316165923.043f4454@canb.auug.org.au> (raw)
In-Reply-To: <20200310144618.GC58231@mit.edu>
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
Hi all,
On Tue, 10 Mar 2020 10:46:18 -0400 "Theodore Y. Ts'o" <tytso@mit.edu> wrote:
>
> On Tue, Mar 10, 2020 at 12:17:47PM +0000, Mark Rutland wrote:
> > On Fri, Mar 06, 2020 at 03:53:48PM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > On Mon, 2 Mar 2020 14:44:52 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > After merging the random tree, today's linux-next build (x86_64
> > > > allnoconfig) produced this warning:
> > > >
> > > > drivers/char/random.c:820:13: warning: 'crng_initialize_secondary' defined but not used [-Wunused-function]
> > > > 820 | static void crng_initialize_secondary(struct crng_state *crng)
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > > >
> > > > Introduced by commit
> > > >
> > > > 5cbe0f13b51a ("random: split primary/secondary crng init paths")
> > >
> > > I am still getting this warning.
> >
> > Sorry, this is my bad.
> >
> > We only call crng_initialize_secondary() in do_numa_crng_init(), which
> > is only built for CONFIG_NUMA. We can either drop both
> > crng_initialize_secondary() and crng_init_try_arch() under the
> > CONFIG_NUMA ifdef, or add __maybe_unused to crng_initialize_secondary().
> >
> > Ted, does the below look ok to you? Or would you prefer moving things
> > under the ifdeffery?
>
> Yes, that looks fine. Reordering the functions to move them under the
> #ifdefs will make the code less readable, and adding extra
> #ifdef/#endif would also make things less readable.
>
> Thanks for the patch, will apply.
How are we going with this?
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-16 5:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 3:44 linux-next: build warning after merge of the random tree Stephen Rothwell
2020-03-06 4:53 ` Stephen Rothwell
2020-03-10 12:17 ` Mark Rutland
2020-03-10 14:46 ` Theodore Y. Ts'o
2020-03-16 5:59 ` Stephen Rothwell [this message]
2020-03-19 3:30 ` Theodore Y. Ts'o
-- strict thread matches above, loose matches on Subject: below --
2018-07-16 5:52 Stephen Rothwell
2018-06-08 3:37 Stephen Rothwell
2018-06-18 3:35 ` Stephen Rothwell
2018-06-18 5:29 ` Tobin C. Harding
2018-07-10 7:26 ` Stephen Rothwell
2017-02-01 6:09 Stephen Rothwell
2014-07-21 7:49 Stephen Rothwell
2013-09-23 4:39 Stephen Rothwell
2013-09-23 4:42 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316165923.043f4454@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox