From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB92EC18E5B for ; Tue, 17 Mar 2020 16:21:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FAAF20735 for ; Tue, 17 Mar 2020 16:21:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Gvn+3uhL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726834AbgCQQVF (ORCPT ); Tue, 17 Mar 2020 12:21:05 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:56762 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726820AbgCQQVF (ORCPT ); Tue, 17 Mar 2020 12:21:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584462063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WfR75tkqDRTnZOFTMReeUHD6jemSmfwExQT5WTS0foc=; b=Gvn+3uhLDsUwg3oLmXTR8NH2K7j6epvPMoi+Zt2682ignkM4kXpm6pv/yCAK70FVP5Dx3S gPN/YdF3/fuV9LAcibRW93cnpnkTqhKE+NPlQAoyKMYU8j1KUJD863lGlYavTomwV3G8/9 mB2mNWAp5XThNrLf49krwgPgDWekB20= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-333--kSeN2m8PoKZCKao7pHumg-1; Tue, 17 Mar 2020 12:20:59 -0400 X-MC-Unique: -kSeN2m8PoKZCKao7pHumg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D227C801E6C; Tue, 17 Mar 2020 16:20:57 +0000 (UTC) Received: from krava (unknown [10.40.195.82]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0DDD25C1BB; Tue, 17 Mar 2020 16:20:54 +0000 (UTC) Date: Tue, 17 Mar 2020 17:20:52 +0100 From: Jiri Olsa To: John Garry Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, will@kernel.org, ak@linux.intel.com, linuxarm@huawei.com, linux-kernel@vger.kernel.org, james.clark@arm.com, qiangqing.zhang@nxp.com Subject: Re: [PATCH v2 2/7] perf jevents: Support test events folder Message-ID: <20200317162052.GD759708@krava> References: <1584442939-8911-1-git-send-email-john.garry@huawei.com> <1584442939-8911-3-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1584442939-8911-3-git-send-email-john.garry@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2020 at 07:02:14PM +0800, John Garry wrote: > With the goal of supporting pmu-events test case, introduce support for= a > test events folder. >=20 > These test events can be used for testing generation of pmu-event table= s > and alias creation for any arch. >=20 > When running the pmu-events test case, these test events will be used > as the platform-agnostic events, so aliases can be created per-PMU and > validated against known expected values. >=20 > To support the test events, add a "testcpu" entry in pmu_events_map[]. > The pmu-events test will be able to lookup the events map for "testcpu"= , > to verify the generated tables against expected values. >=20 > The resultant generated pmu-events.c will now look like the following: can't compile this one: HOSTCC pmu-events/jevents.o pmu-events/jevents.c: In function =E2=80=98main=E2=80=99: pmu-events/jevents.c:1195:3: error: =E2=80=98ret=E2=80=99 undeclared (fir= st use in this function) 1195 | ret =3D 1; | ^~~ pmu-events/jevents.c:1195:3: note: each undeclared identifier is reported= only once for each function it appears in pmu-events/jevents.c:1196:3: error: label =E2=80=98out_free_mapfile=E2=80= =99 used but not defined 1196 | goto out_free_mapfile; | ^~~~ mv: cannot stat 'pmu-events/.jevents.o.tmp': No such file or directory make[3]: *** [/home/jolsa/kernel/linux-perf/tools/build/Makefile.build:97= : pmu-events/jevents.o] Error 1 make[2]: *** [Makefile.perf:619: pmu-events/jevents-in.o] Error 2 make[1]: *** [Makefile.perf:225: sub-make] Error 2 make: *** [Makefile:70: all] Error 2 jirka