Re: [PATCH V6 8/8] virtio: Intel IFC VF driver for VDPA

kbuild test robot
2020-03-18T13:31:06Z

[-- Attachment #1: Type: text/plain, Size: 3979 bytes --]

Hi Jason,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on vhost/linux-next]
[also build test ERROR on linux/master linus/master v5.6-rc6 next-20200317]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200318-191435
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=sh

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/virtio/vdpa/ifcvf/ifcvf_main.c: In function 'ifcvf_probe':
drivers/virtio/vdpa/ifcvf/ifcvf_main.c:409:30: error: implicit declaration of function 'pci_iomap_range'; did you mean 'pci_unmap_page'? [-Werror=implicit-function-declaration]
409 | vf->mem_resource[i].addr = pci_iomap_range(pdev, i, 0,
| ^~~~~~~~~~~~~~~
| pci_unmap_page
drivers/virtio/vdpa/ifcvf/ifcvf_main.c:409:28: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
409 | vf->mem_resource[i].addr = pci_iomap_range(pdev, i, 0,
| ^
drivers/virtio/vdpa/ifcvf/ifcvf_main.c:443:2: error: implicit declaration of function 'pci_free_irq_vectors'; did you mean 'pci_alloc_irq_vectors'? [-Werror=implicit-function-declaration]
443 | pci_free_irq_vectors(pdev);
| ^~~~~~~~~~~~~~~~~~~~
| pci_alloc_irq_vectors
drivers/virtio/vdpa/ifcvf/ifcvf_main.c: In function 'ifcvf_remove':
>> drivers/virtio/vdpa/ifcvf/ifcvf_main.c:463:4: error: implicit declaration of function 'pci_iounmap'; did you mean 'pcim_iounmap'? [-Werror=implicit-function-declaration]
463 | pci_iounmap(pdev, vf->mem_resource[i].addr);
| ^~~~~~~~~~~
| pcim_iounmap
drivers/virtio/vdpa/ifcvf/ifcvf_main.c: At top level:
drivers/virtio/vdpa/ifcvf/ifcvf_main.c:491:1: warning: data definition has no type or storage class
491 | module_pci_driver(ifcvf_driver);
| ^~~~~~~~~~~~~~~~~
drivers/virtio/vdpa/ifcvf/ifcvf_main.c:491:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int]
drivers/virtio/vdpa/ifcvf/ifcvf_main.c:491:1: warning: parameter names (without types) in function declaration
drivers/virtio/vdpa/ifcvf/ifcvf_main.c:484:26: warning: 'ifcvf_driver' defined but not used [-Wunused-variable]
484 | static struct pci_driver ifcvf_driver = {
| ^~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +463 drivers/virtio/vdpa/ifcvf/ifcvf_main.c

452
453 static void ifcvf_remove(struct pci_dev *pdev)
454 {
455 struct ifcvf_adapter *adapter = pci_get_drvdata(pdev);
456 struct ifcvf_hw *vf;
457 int i;
458
459 ifcvf_vdpa_detach(adapter);
460 vf = &adapter->vf;
461 for (i = 0; i < IFCVF_PCI_MAX_RESOURCE; i++) {
462 if (vf->mem_resource[i].addr) {
> 463 pci_iounmap(pdev, vf->mem_resource[i].addr);
464 vf->mem_resource[i].addr = NULL;
465 }
466 }
467
468 ifcvf_destroy_adapter(adapter);
469 pci_free_irq_vectors(pdev);
470 pci_release_regions(pdev);
471 pci_disable_device(pdev);
472 kfree(adapter);
473 }
474

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53803 bytes --]