From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E9EC5ACD6 for ; Wed, 18 Mar 2020 12:00:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 724C020771 for ; Wed, 18 Mar 2020 12:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584532804; bh=2H+so29I1hHe3xQD8MKyVrF7XGPXr84xf8iAW0ZX98E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=f8nrWMz8KTCfcTnob5zBgcffvDYScsqw0moKCGP3dGBrXJX/7Gr8SYbXD4mMDQYm/ Hup+RThUOahJjN9A/HypKceLX6BACp4ESTzkU5xtGhG0pTthLksm4tqTmhn1CxEJjq /XTHijdA350cMk9CQC8iLJ6Cm6nmdsDwt5iu6sv0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbgCRMAD (ORCPT ); Wed, 18 Mar 2020 08:00:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:37372 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726473AbgCRMAD (ORCPT ); Wed, 18 Mar 2020 08:00:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3B2EB2076D; Wed, 18 Mar 2020 12:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584532802; bh=2H+so29I1hHe3xQD8MKyVrF7XGPXr84xf8iAW0ZX98E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u6MsJOuxVuceM4VOUZ9JHpxrDQZ3Wg2nc7mKLOjzz6KB1g3TpHiaw81uCulqu0ZaA aqI6Q/mwOvWZ/jwldBiUGRtmiCaGPkUDe5P9BLmH46ore269mSWsKnD/c1GtqviDMT 1qDa1F/80Lv0mMnggZlQNZhD0m6SEc1DzUmLdGuw= Date: Wed, 18 Mar 2020 13:00:00 +0100 From: Greg Kroah-Hartman To: Eric Biggers Cc: Jiri Slaby , linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Al Viro Subject: Re: [PATCH v2 1/2] tty: fix compat TIOCGSERIAL leaking uninitialized memory Message-ID: <20200318120000.GA2528302@kroah.com> References: <20200224181532.GA109047@gmail.com> <20200224182044.234553-1-ebiggers@kernel.org> <20200224182044.234553-2-ebiggers@kernel.org> <6294851f-50e5-eaaa-2182-1ad6ae7234b1@suse.com> <20200302212425.GB78660@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200302212425.GB78660@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 02, 2020 at 01:24:25PM -0800, Eric Biggers wrote: > On Tue, Feb 25, 2020 at 08:30:35AM +0100, Jiri Slaby wrote: > > On 24. 02. 20, 19:20, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > Commit 77654350306a ("take compat TIOC[SG]SERIAL treatment into > > > tty_compat_ioctl()") changed the compat version of TIOCGSERIAL to start > > > copying a whole 'serial_struct32' to userspace rather than individual > > > fields, but failed to initialize all padding and fields -- namely the > > > hole after the 'iomem_reg_shift' field, and the 'reserved' field. > > > > > > Fix this by initializing the struct to zero. > > > > > > [v2: use sizeof, and convert the adjacent line for consistency.] > > > > > > Reported-by: syzbot+8da9175e28eadcb203ce@syzkaller.appspotmail.com > > > Fixes: 77654350306a ("take compat TIOC[SG]SERIAL treatment into tty_compat_ioctl()") > > > Cc: # v4.20+ > > > Signed-off-by: Eric Biggers > > > > Acked-by: Jiri Slaby > > > > Thanks. Greg, are you planning to take these patches? Yes, sorry, they were not cc: linux-serial and fell through my initial filters, to go into my generic "to-review" bucket. Will take them now... greg k-h