Re: [PATCH v6 1/3] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings

Rob Herring
2020-03-19T17:21:36Z

On Wed, Mar 18, 2020 at 11:37 PM Taniya Das <tdas@codeaurora.org> wrote:
>
>
>
> On 3/19/2020 3:34 AM, Rob Herring wrote:
> > On Sun, 15 Mar 2020 00:19:56 +0530, Taniya Das wrote:
> >> The Modem Subsystem clock provider have a bunch of generic properties
> >> that are needed in a device tree. Add a YAML schemas for those.
> >>
> >> Add clock ids for GCC MSS and MSS clocks which are required to bring
> >> the modem out of reset.
> >>
> >> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> >> ---
> >> .../devicetree/bindings/clock/qcom,sc7180-mss.yaml | 62 ++++++++++++++++++++++
> >> include/dt-bindings/clock/qcom,gcc-sc7180.h | 7 ++-
> >> include/dt-bindings/clock/qcom,mss-sc7180.h | 12 +++++
> >> 3 files changed, 80 insertions(+), 1 deletion(-)
> >> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml
> >> create mode 100644 include/dt-bindings/clock/qcom,mss-sc7180.h
> >>
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml: $id: relative path/filename doesn't match actual path or filename
> > expected: http://devicetree.org/schemas/clock/qcom,sc7180-mss.yaml#
> >
> > See https://patchwork.ozlabs.org/patch/1254940
> > Please check and re-submit.
> >
> Hi Rob,
>
> Thanks, I have fixed it in the next patch series.
>
> Is there a way to catch these before submitting? As I do not see these
> errors on my machine.

If you ran 'make dt_binding_check' already, then update dt-schema with pip.

Rob