Re: [PATCH v6 1/3] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings

Stephen Boyd
2020-03-19T00:30:12Z

Quoting Taniya Das (2020-03-14 11:49:56)
> The Modem Subsystem clock provider have a bunch of generic properties
> that are needed in a device tree. Add a YAML schemas for those.
>
> Add clock ids for GCC MSS and MSS clocks which are required to bring
> the modem out of reset.
>
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---
> .../devicetree/bindings/clock/qcom,sc7180-mss.yaml | 62 ++++++++++++++++++++++
> include/dt-bindings/clock/qcom,gcc-sc7180.h | 7 ++-
> include/dt-bindings/clock/qcom,mss-sc7180.h | 12 +++++
> 3 files changed, 80 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml
> create mode 100644 include/dt-bindings/clock/qcom,mss-sc7180.h
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml
> new file mode 100644
> index 0000000..72493dd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/clock/qcom,sc7180-mss.yaml#

remove 'bindings' above.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Modem Clock Controller Binding
> +
> +maintainers:
> + - Taniya Das <tdas@codeaurora.org>
> +
> +description: |
> + Qualcomm modem clock control module which supports the clocks.
> +
> + See also dt-bindings/clock/qcom,mss-sc7180.h.

Can you follow how for example gcc-sc7180 does this?

See also:
- dt-bindings/clock/qcom,mss-sc7180.h