From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM list <linux-pm@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: linux-next: Tree for Mar 18 (drivers/base/power/sysfs.c)
Date: Thu, 19 Mar 2020 14:20:02 +1100 [thread overview]
Message-ID: <20200319142002.7382ed70@canb.auug.org.au> (raw)
In-Reply-To: <1c7d78ba-55ae-6f8c-9a4f-13aca32f59de@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 3283 bytes --]
Hi Randy,
On Wed, 18 Mar 2020 09:14:29 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> on i386:
>
> ../drivers/base/power/sysfs.c: In function ‘dpm_sysfs_change_owner’:
> ../drivers/base/power/sysfs.c:708:44: error: passing argument 2 of ‘sysfs_group_change_owner’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> rc = sysfs_group_change_owner(&dev->kobj, &pm_attr_group, kuid, kgid);
> ^
> In file included from ../include/linux/kobject.h:20:0,
> from ../include/linux/device.h:17,
> from ../drivers/base/power/sysfs.c:3:
> ../include/linux/sysfs.h:576:19: note: expected ‘const struct attribute_group **’ but argument is of type ‘const struct attribute_group *’
> static inline int sysfs_group_change_owner(struct kobject *kobj,
> ^~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/base/power/sysfs.c:714:16: error: passing argument 2 of ‘sysfs_group_change_owner’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> &dev->kobj, &pm_runtime_attr_group, kuid, kgid);
> ^
> In file included from ../include/linux/kobject.h:20:0,
> from ../include/linux/device.h:17,
> from ../drivers/base/power/sysfs.c:3:
> ../include/linux/sysfs.h:576:19: note: expected ‘const struct attribute_group **’ but argument is of type ‘const struct attribute_group *’
> static inline int sysfs_group_change_owner(struct kobject *kobj,
> ^~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/base/power/sysfs.c:720:45: error: passing argument 2 of ‘sysfs_group_change_owner’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> rc = sysfs_group_change_owner(&dev->kobj, &pm_wakeup_attr_group,
> ^
> In file included from ../include/linux/kobject.h:20:0,
> from ../include/linux/device.h:17,
> from ../drivers/base/power/sysfs.c:3:
> ../include/linux/sysfs.h:576:19: note: expected ‘const struct attribute_group **’ but argument is of type ‘const struct attribute_group *’
> static inline int sysfs_group_change_owner(struct kobject *kobj,
> ^~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/base/power/sysfs.c:732:16: error: passing argument 2 of ‘sysfs_group_change_owner’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> &dev->kobj, &pm_qos_latency_tolerance_attr_group, kuid,
> ^
> In file included from ../include/linux/kobject.h:20:0,
> from ../include/linux/device.h:17,
> from ../drivers/base/power/sysfs.c:3:
> ../include/linux/sysfs.h:576:19: note: expected ‘const struct attribute_group **’ but argument is of type ‘const struct attribute_group *’
> static inline int sysfs_group_change_owner(struct kobject *kobj,
> ^~~~~~~~~~~~~~~~~~~~~~~~
Caused by commitCONFIG_SYSFS
303a42769c4c ("sysfs: add sysfs_group{s}_change_owner()")
from the net-next tree.
The CONFIG_SYSFS declaration of sysfs_group_change_owner() is different
from the !CONFIG_SYSFS version.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-19 3:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 11:09 linux-next: Tree for Mar 18 Stephen Rothwell
2020-03-18 16:14 ` linux-next: Tree for Mar 18 (drivers/base/power/sysfs.c) Randy Dunlap
2020-03-19 3:20 ` Stephen Rothwell [this message]
2020-03-19 14:47 ` [PATCH net-next] sysfs: fix static inline declaration of sysfs_groups_change_owner() Christian Brauner
2020-03-19 16:19 ` Randy Dunlap
2020-03-20 4:17 ` David Miller
2020-03-18 16:48 ` linux-next: Tree for Mar 18 (objtool) Randy Dunlap
2020-03-18 16:55 ` Josh Poimboeuf
2020-03-18 18:23 ` Josh Poimboeuf
2020-03-18 20:05 ` Peter Zijlstra
2020-03-19 11:12 ` Peter Zijlstra
2020-03-19 17:31 ` Josh Poimboeuf
2020-03-19 17:33 ` Josh Poimboeuf
2020-03-19 17:40 ` Josh Poimboeuf
2020-03-19 17:45 ` Josh Poimboeuf
2020-03-20 8:26 ` Peter Zijlstra
2020-03-20 18:35 ` Kees Cook
2020-03-24 16:44 ` Josh Poimboeuf
2020-03-24 18:18 ` Kees Cook
2020-03-24 22:24 ` Josh Poimboeuf
2020-03-26 5:57 ` Kees Cook
2020-03-26 16:31 ` Josh Poimboeuf
2020-03-26 18:36 ` Kees Cook
2020-03-27 3:55 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319142002.7382ed70@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=christian.brauner@ubuntu.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox