From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE0DEC4332E for ; Thu, 19 Mar 2020 03:20:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81C412076C for ; Thu, 19 Mar 2020 03:20:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="s+c8gZbn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726855AbgCSDUP (ORCPT ); Wed, 18 Mar 2020 23:20:15 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:41651 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbgCSDUP (ORCPT ); Wed, 18 Mar 2020 23:20:15 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 48jXGK5lGkz9sPF; Thu, 19 Mar 2020 14:20:09 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1584588011; bh=Ai9OhofFDo+Kuv8/Q1oIJL9PA57GRqNhOuVclO2kkAQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s+c8gZbnoR5P6CdeA8jyGK9OfV1C3G7SUDQ7Nas7JVbCu+DqEBYmrEDotfFuTR5H/ J4ND90uHfyIyRgUygj2rR9q/zPgXuk7hg9JY/wPf2s7QQWtQpOvu7t9CohWybgd/T7 AIEX+YN3astnwwL4hmok5SGbKEHdx/BQ6I5KbNxst7Uai3hVNM9vaeVBvtx3DLNBm7 iTisZ82te70xQFnole+4mgCg48iJXRU/CcEVODRUDx8+6UQvW90kAZ0uDhyEURIra8 06cWKyldIT1cccLPRjZT1zk5tPGasgfNYYO00YWNutYavRkU1CY5Yu5aFrFvdcX786 d+tMcdQAZcGTw== Date: Thu, 19 Mar 2020 14:20:02 +1100 From: Stephen Rothwell To: Christian Brauner Cc: Randy Dunlap , Linux Next Mailing List , Linux Kernel Mailing List , Greg Kroah-Hartman , "Rafael J. Wysocki" , Linux PM list , "David S. Miller" Subject: Re: linux-next: Tree for Mar 18 (drivers/base/power/sysfs.c) Message-ID: <20200319142002.7382ed70@canb.auug.org.au> In-Reply-To: <1c7d78ba-55ae-6f8c-9a4f-13aca32f59de@infradead.org> References: <20200318220920.48df2e76@canb.auug.org.au> <1c7d78ba-55ae-6f8c-9a4f-13aca32f59de@infradead.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/OzymEXv09uqzpaSswDv9a8x"; protocol="application/pgp-signature"; micalg=pgp-sha256 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/OzymEXv09uqzpaSswDv9a8x Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Randy, On Wed, 18 Mar 2020 09:14:29 -0700 Randy Dunlap wro= te: > > on i386: >=20 > ../drivers/base/power/sysfs.c: In function =E2=80=98dpm_sysfs_change_owne= r=E2=80=99: > ../drivers/base/power/sysfs.c:708:44: error: passing argument 2 of =E2=80= =98sysfs_group_change_owner=E2=80=99 from incompatible pointer type [-Werro= r=3Dincompatible-pointer-types] > rc =3D sysfs_group_change_owner(&dev->kobj, &pm_attr_group, kuid, kgid); > ^ > In file included from ../include/linux/kobject.h:20:0, > from ../include/linux/device.h:17, > from ../drivers/base/power/sysfs.c:3: > ../include/linux/sysfs.h:576:19: note: expected =E2=80=98const struct att= ribute_group **=E2=80=99 but argument is of type =E2=80=98const struct attr= ibute_group *=E2=80=99 > static inline int sysfs_group_change_owner(struct kobject *kobj, > ^~~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/base/power/sysfs.c:714:16: error: passing argument 2 of =E2=80= =98sysfs_group_change_owner=E2=80=99 from incompatible pointer type [-Werro= r=3Dincompatible-pointer-types] > &dev->kobj, &pm_runtime_attr_group, kuid, kgid); > ^ > In file included from ../include/linux/kobject.h:20:0, > from ../include/linux/device.h:17, > from ../drivers/base/power/sysfs.c:3: > ../include/linux/sysfs.h:576:19: note: expected =E2=80=98const struct att= ribute_group **=E2=80=99 but argument is of type =E2=80=98const struct attr= ibute_group *=E2=80=99 > static inline int sysfs_group_change_owner(struct kobject *kobj, > ^~~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/base/power/sysfs.c:720:45: error: passing argument 2 of =E2=80= =98sysfs_group_change_owner=E2=80=99 from incompatible pointer type [-Werro= r=3Dincompatible-pointer-types] > rc =3D sysfs_group_change_owner(&dev->kobj, &pm_wakeup_attr_group, > ^ > In file included from ../include/linux/kobject.h:20:0, > from ../include/linux/device.h:17, > from ../drivers/base/power/sysfs.c:3: > ../include/linux/sysfs.h:576:19: note: expected =E2=80=98const struct att= ribute_group **=E2=80=99 but argument is of type =E2=80=98const struct attr= ibute_group *=E2=80=99 > static inline int sysfs_group_change_owner(struct kobject *kobj, > ^~~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/base/power/sysfs.c:732:16: error: passing argument 2 of =E2=80= =98sysfs_group_change_owner=E2=80=99 from incompatible pointer type [-Werro= r=3Dincompatible-pointer-types] > &dev->kobj, &pm_qos_latency_tolerance_attr_group, kuid, > ^ > In file included from ../include/linux/kobject.h:20:0, > from ../include/linux/device.h:17, > from ../drivers/base/power/sysfs.c:3: > ../include/linux/sysfs.h:576:19: note: expected =E2=80=98const struct att= ribute_group **=E2=80=99 but argument is of type =E2=80=98const struct attr= ibute_group *=E2=80=99 > static inline int sysfs_group_change_owner(struct kobject *kobj, > ^~~~~~~~~~~~~~~~~~~~~~~~ Caused by commitCONFIG_SYSFS 303a42769c4c ("sysfs: add sysfs_group{s}_change_owner()") from the net-next tree. The CONFIG_SYSFS declaration of sysfs_group_change_owner() is different from the !CONFIG_SYSFS version. --=20 Cheers, Stephen Rothwell --Sig_/OzymEXv09uqzpaSswDv9a8x Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl5y5OIACgkQAVBC80lX 0GxRxwf/bZRlfZbDsOLE5GMYUz6Wd9HdJhOP8f3ZeuKS/Q3m+rYVHI6bc83jwgA2 8oqocs60tkJ1XwIrDQ7ue77QnTJZGYxL/8kiPavtszwZYB+SrmVhH5bHKmkKssks aSmz4NpNNo00yhU9TE7pXs4VdXN0ejc59lkDgD0gGS6YBUHAjgQJBkODUak1mjV1 VboVQb/HPIp1LCx2+r0vriZOUqxtxBTcxMZeIeFIWzQNsx4wSh6SX+hoITNcbwIz 855QOgv6ebOYNlSTFxHNrGPziHz/W9xDltsicKy3PcEBizn7uHkJgBNN/Yd8QZWt KOa02FeHTmuBvecjJ7rzpnF0afaxNQ== =Xfd+ -----END PGP SIGNATURE----- --Sig_/OzymEXv09uqzpaSswDv9a8x--