From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B2CAC4332B for ; Fri, 20 Mar 2020 11:05:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 439F120732 for ; Fri, 20 Mar 2020 11:05:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="aPld3xt5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727305AbgCTLFL (ORCPT ); Fri, 20 Mar 2020 07:05:11 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:51204 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726821AbgCTLFL (ORCPT ); Fri, 20 Mar 2020 07:05:11 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02KAqoZr172799; Fri, 20 Mar 2020 11:05:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=o4Vz3fMAmZkMeyHbxS+8hpupOxZL84r2sZTkvZwv2TA=; b=aPld3xt5QB1tpf0S/l/XsymqRbglqGjRO/SKdGikGwgD8wITajZ4PXrRdOJjhpOzS7JS 1NU6Bva/U6V1XS4SETE8zju1M/4muLci4WAp5CZpTZq32thu/0xQKErY1z+FGr7lzjFz 0NQ5z64Dv0FrYeTaXwRBfFdcJlKaeaKrZmBiib0Qd8yVDZ9ccuolQGe+K0MQGlXxDE0Q 68UzIXJimCctD5OS+il9KKCNbvq3zZVW/c0T5lnnqiSG37K0Q+n/+BOkAB0eZRyZxOSJ de/bkYlpndGjHTbvFDr/cq08GT68SynL9Xka6qiymek7TLHBn6FDedXvkntHRUbCIPP8 Tw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2yrq7mcxyw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Mar 2020 11:05:03 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02KAq1A7150692; Fri, 20 Mar 2020 11:05:02 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2ys92q5hdn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Mar 2020 11:05:02 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02KB51rl025349; Fri, 20 Mar 2020 11:05:01 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 20 Mar 2020 04:05:00 -0700 Date: Fri, 20 Mar 2020 14:04:53 +0300 From: Dan Carpenter To: Camylla Cantanheide Cc: Joe Perches , Greg Kroah-Hartman , devel@driverdev.osuosl.org, LKML , lkcamp@lists.libreplanetbr.org Subject: Re: [PATCH 2/2] staging: rtl8192u: Corrects 'Avoid CamelCase' for variables Message-ID: <20200320110453.GA4672@kadam> References: <20200317085130.21213-1-c.cantanheide@gmail.com> <20200317085130.21213-2-c.cantanheide@gmail.com> <20200317134329.GC4650@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9565 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 mlxscore=0 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003200048 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9565 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 priorityscore=1501 clxscore=1015 malwarescore=0 mlxscore=0 phishscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003200048 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2020 at 02:31:27PM -0300, Camylla Cantanheide wrote: > Dear Dan Carpenter and Joe Perches, > > Thank you very much for the suggestions, I found the evaluation of both > very significant. Now, I have another perspective on variables. > > I solved the problem for the *setKey *function, however, when executing the > checkpatch, more *Checks* of the same type appeared. If your changed introduces more warnings then you should fix them. Like say you rename variables and now the line goes over 80 characters, then fix the new 80 character warning. But if it was already over 80 characters then ignore the warning. > > Should I send the second version of the patch, only to the *setKey* > function or do I resolve all *Checks* for the entire file? We want patches which are easy to review. If you change everything in the file, it will probably be too complicated for me to review. So I guess ignore those warnings. regards, dan carpenter