Re: [PATCH v3 0/2] vt: fix some vt_ioctl races

Greg Kroah-Hartman
2020-03-24T11:29:50Z

On Sat, Mar 21, 2020 at 08:43:03PM -0700, Eric Biggers wrote:
> Fix VT_DISALLOCATE freeing an in-use virtual console, and fix a
> use-after-free in vt_in_use().
>
> Changed since v2:
> - Implemented tty_port_operations::destruct().
> - Added comments regarding vt_in_use() locking.
>
> Changed since v1:
> - Made the vc_data be freed via tty_port refcounting.
> - Added patch to fix a use-after-free in vt_in_use().
>
> Eric Biggers (2):
> vt: vt_ioctl: fix VT_DISALLOCATE freeing in-use virtual console
> vt: vt_ioctl: fix use-after-free in vt_in_use()
>
> drivers/tty/vt/vt.c | 23 ++++++++++++++++++++++-
> drivers/tty/vt/vt_ioctl.c | 28 ++++++++++++++++------------
> 2 files changed, 38 insertions(+), 13 deletions(-)

Jiri, any objection to these?

thanks,

greg k-h