From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CF03C4332B for ; Sat, 21 Mar 2020 05:16:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F9C320714 for ; Sat, 21 Mar 2020 05:16:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jq8uYH4K" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727995AbgCUFQR (ORCPT ); Sat, 21 Mar 2020 01:16:17 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:41515 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725440AbgCUFQQ (ORCPT ); Sat, 21 Mar 2020 01:16:16 -0400 Received: by mail-pg1-f195.google.com with SMTP id b1so4134925pgm.8 for ; Fri, 20 Mar 2020 22:16:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XNi67lxb8U8NV5u7Vn404GtWj+hZ0U+9yVzYkz6He6c=; b=jq8uYH4KlVRzXv1z55n7X7m51bZgjDN7PaeFcN5NkEvGni89YjKSeIk1kY1qugZ2EW A2oUo07JhAZvwb6/Awi0TCpenPbNi8CujHTpna1iApfqArhDl0pHhWMY/zX20I+ZTfMV wYGuRj0e+22DUP2xtisJw0EabKIUIZ90TprLg087ujThJ0CTRoxsqE2/tNrzcEzT3SLw naQSXNKV23pdQ5DBrd+B64G5uOajpwStBJOPChgD7/VDf4jb1bbbZ8k+gFFFVnlv/mlY 6R8BcXlqX8wcYF0H4m7kpMAD4q4jZcg4zM+6vHjBScFw8RLaVTvdzN+5RkZAoGwqBPbc 9N4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XNi67lxb8U8NV5u7Vn404GtWj+hZ0U+9yVzYkz6He6c=; b=cM4CpRlFuAFrv6CMlN8sLq0V1gC5VdL8QFSNd6WkswWBwuStSu9A1YG7fXpZSXWJeB cEWeVDUGaxiZENBfmd3AVyzD1/okWxBPor5ryTDe2Dvz/5D+R9pkcUXPk19ffqPi6NqF VBv92QqKpQbfIDcvozrVZRie6txx0JFSBL4Z/loDpNECxhVhfn7nki+FJ+3EgBbK37OB OGH3jQuu3gG522v9+T0LJhp+GuM7fbdpXNSeV8FBPfwge1YSuPgWQzcIqDFSNAiacGtu pusWZeUmtyiCnaTYOMG7Vwy4SWwCNRdVZgFGVnYtnq3xGxYwpKNhvezvT0lvzLdiSfp/ lBbw== X-Gm-Message-State: ANhLgQ2CvUovoYTG5y/Lk1RprWrFbNSKlHtnQFxOzuoNJfQOg8fRs6Cr QtoQTEEIRatAUFjsopg7TzhdJg== X-Google-Smtp-Source: ADFU+vs2kNydDTd3Wn+dEAvpwU9bUvPxix2ypzpJD/vmL+TvIzEbcNGfc+1iSt2ank04tWaOQaCaVQ== X-Received: by 2002:a63:18b:: with SMTP id 133mr2609937pgb.422.1584767775753; Fri, 20 Mar 2020 22:16:15 -0700 (PDT) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id i11sm6170637pje.30.2020.03.20.22.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2020 22:16:15 -0700 (PDT) Date: Fri, 20 Mar 2020 22:16:12 -0700 From: Bjorn Andersson To: Stephen Boyd Cc: Michael Turquette , Rob Herring , Andy Gross , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Clark Subject: Re: [PATCH 2/4] clk: qcom: mmcc-msm8996: Properly describe GPU_GX gdsc Message-ID: <20200321051612.GA5063@builder> References: <20200319053902.3415984-1-bjorn.andersson@linaro.org> <20200319053902.3415984-3-bjorn.andersson@linaro.org> <158474710844.125146.15515925711513283888@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <158474710844.125146.15515925711513283888@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 20 Mar 16:31 PDT 2020, Stephen Boyd wrote: > Quoting Bjorn Andersson (2020-03-18 22:39:00) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > index 85518494ce43..65d9aa790581 100644 > > --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml > > @@ -67,6 +67,10 @@ properties: > > description: > > Protected clock specifier list as per common clock binding > > > > + vdd_gfx-supply: > > Why not vdd-gfx-supply? What's with the underscore? > The pad is named "VDD_GFX" in the datasheet and the schematics. I see that we've started y/_/-/ in some of the newly added bindings, would you prefer I follow this? Regards, Bjorn > > + description: > > + Regulator supply for the GPU_GX GDSC > > + > > required: > > - compatible > > - reg