* [PATCH 1/2] iio: dac: ad5770r: read channel nr from reg
2020-03-20 16:05 [PATCH 0/2] iio: dac: ad5770r: dt bindings fixes Alexandru Tachici
@ 2020-03-20 16:05 ` Alexandru Tachici
2020-03-20 16:05 ` [PATCH 2/2] dt-bindings: iio: dac: AD5570R fix bindings errors Alexandru Tachici
2020-03-21 7:17 ` [PATCH 0/2] iio: dac: ad5770r: dt bindings fixes Ardelean, Alexandru
2 siblings, 0 replies; 5+ messages in thread
From: Alexandru Tachici @ 2020-03-20 16:05 UTC (permalink / raw)
To: linux-iio, linux-kernel; +Cc: jic23
Read channel number from the reg property of each child
node.
Fixes: cbbb819837f6 ("iio: dac: ad5770r: Add AD5770R support")
Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
---
drivers/iio/dac/ad5770r.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/ad5770r.c b/drivers/iio/dac/ad5770r.c
index a98ea76732e7..6302f11551d4 100644
--- a/drivers/iio/dac/ad5770r.c
+++ b/drivers/iio/dac/ad5770r.c
@@ -522,7 +522,7 @@ static int ad5770r_channel_config(struct ad5770r_state *st)
return -EINVAL;
device_for_each_child_node(&st->spi->dev, child) {
- ret = fwnode_property_read_u32(child, "num", &num);
+ ret = fwnode_property_read_u32(child, "reg", &num);
if (ret)
return ret;
if (num > AD5770R_MAX_CHANNELS)
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] dt-bindings: iio: dac: AD5570R fix bindings errors
2020-03-20 16:05 [PATCH 0/2] iio: dac: ad5770r: dt bindings fixes Alexandru Tachici
2020-03-20 16:05 ` [PATCH 1/2] iio: dac: ad5770r: read channel nr from reg Alexandru Tachici
@ 2020-03-20 16:05 ` Alexandru Tachici
2020-03-21 7:17 ` [PATCH 0/2] iio: dac: ad5770r: dt bindings fixes Ardelean, Alexandru
2 siblings, 0 replies; 5+ messages in thread
From: Alexandru Tachici @ 2020-03-20 16:05 UTC (permalink / raw)
To: linux-iio, linux-kernel; +Cc: jic23
Replaced num property with reg property, fixed errors
reported by dt-binding-check.
Fixes: ea52c21268e6 ("iio: dac: ad5770r: Add AD5770R support")
Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
---
.../bindings/iio/dac/adi,ad5770r.yaml | 77 ++++++++++---------
1 file changed, 40 insertions(+), 37 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
index d9c25cf4b92f..d1755dbc1a41 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
@@ -2,7 +2,7 @@
# Copyright 2020 Analog Devices Inc.
%YAML 1.2
---
-$id: http://devicetree.org/schemas/bindings/iio/dac/adi,ad5770r.yaml#
+$id: http://devicetree.org/schemas/iio/dac/adi,ad5770r.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
title: Analog Devices AD5770R DAC device driver
@@ -49,83 +49,84 @@ properties:
asserted during driver probe.
maxItems: 1
- channel0:
+ channel@0:
description: Represents an external channel which are
connected to the DAC. Channel 0 can act both as a current
source and sink.
type: object
properties:
- num:
+ reg:
description: This represents the channel number.
- items:
- const: 0
adi,range-microamp:
description: Output range of the channel.
oneOf:
- - $ref: /schemas/types.yaml#/definitions/int32-array
- items:
- - enum: [0 300000]
- - enum: [-60000 0]
- - enum: [-60000 300000]
+ - const: 0
+ - const: 300000
+ - items:
+ - const: -60000
+ - const: 0
+ - items:
+ - const: -60000
+ - const: 300000
- channel1:
+ channel@1:
description: Represents an external channel which are
connected to the DAC.
type: object
properties:
- num:
+ reg:
description: This represents the channel number.
- items:
- const: 1
adi,range-microamp:
description: Output range of the channel.
oneOf:
- - $ref: /schemas/types.yaml#/definitions/uint32-array
- items:
- - enum: [0 140000]
- - enum: [0 250000]
+ - const: 0
+ - const: 140000
+ - items:
+ - const: 0
+ - const: 250000
- channel2:
+ channel@2:
description: Represents an external channel which are
connected to the DAC.
type: object
properties:
- num:
+ reg:
description: This represents the channel number.
- items:
- const: 2
adi,range-microamp:
description: Output range of the channel.
oneOf:
- - $ref: /schemas/types.yaml#/definitions/uint32-array
- items:
- - enum: [0 140000]
- - enum: [0 250000]
+ - const: 0
+ - const: 55000
+ - items:
+ - const: 0
+ - const: 150000
patternProperties:
"^channel@([3-5])$":
type: object
description: Represents the external channels which are connected to the DAC.
properties:
- num:
+ reg:
description: This represents the channel number.
- items:
- minimum: 3
- maximum: 5
adi,range-microamp:
description: Output range of the channel.
oneOf:
- - $ref: /schemas/types.yaml#/definitions/uint32-array
- items:
- - enum: [0 45000]
- - enum: [0 100000]
+ - const: 0
+ - const: 45000
+ - items:
+ - const: 0
+ - const: 100000
required:
- reg
@@ -150,34 +151,36 @@ examples:
vref-supply = <&vref>;
adi,external-resistor;
reset-gpios = <&gpio 22 0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
channel@0 {
- num = <0>;
- adi,range-microamp = <(-60000) 300000>;
+ reg = <0>;
+ adi,range-microamp = <0 300000>;
};
channel@1 {
- num = <1>;
+ reg = <1>;
adi,range-microamp = <0 140000>;
};
channel@2 {
- num = <2>;
+ reg = <2>;
adi,range-microamp = <0 55000>;
};
channel@3 {
- num = <3>;
+ reg = <3>;
adi,range-microamp = <0 45000>;
};
channel@4 {
- num = <4>;
+ reg = <4>;
adi,range-microamp = <0 45000>;
};
channel@5 {
- num = <5>;
+ reg = <5>;
adi,range-microamp = <0 45000>;
};
};
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 0/2] iio: dac: ad5770r: dt bindings fixes
2020-03-20 16:05 [PATCH 0/2] iio: dac: ad5770r: dt bindings fixes Alexandru Tachici
2020-03-20 16:05 ` [PATCH 1/2] iio: dac: ad5770r: read channel nr from reg Alexandru Tachici
2020-03-20 16:05 ` [PATCH 2/2] dt-bindings: iio: dac: AD5570R fix bindings errors Alexandru Tachici
@ 2020-03-21 7:17 ` Ardelean, Alexandru
2020-03-21 17:27 ` Jonathan Cameron
2 siblings, 1 reply; 5+ messages in thread
From: Ardelean, Alexandru @ 2020-03-21 7:17 UTC (permalink / raw)
To: tachicialex@gmail.com, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Cc: jic23@kernel.org
On Fri, 2020-03-20 at 18:05 +0200, Alexandru Tachici wrote:
> [External]
>
> This aims to replace use of num property from dt nodes with
> reg property both in dt bindings and driver and fix
> dt bindings errors.
>
Maybe do a RESEND for this and add
--to=devicetree@vger.kernel.org --cc=robh+dt@kernel.org
to the git send-mail command
Specifically for this, the DT list should be addressed.
But [naturally] the IIO list should also be included.
> 1. read from fwnode reg property instead of num property
>
> 2. replace num property with reg property and fix dt
> bindings errors
>
> Alexandru Tachici (2):
> iio: dac: ad5770r: read channel nr from reg
> dt-bindings: iio: dac: AD5570R fix bindings errors
>
> .../bindings/iio/dac/adi,ad5770r.yaml | 77 ++++++++++---------
> drivers/iio/dac/ad5770r.c | 2 +-
> 2 files changed, 41 insertions(+), 38 deletions(-)
>
^ permalink raw reply [flat|nested] 5+ messages in thread