From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BDC3C4332B for ; Sat, 21 Mar 2020 18:33:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 588252076E for ; Sat, 21 Mar 2020 18:33:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727718AbgCUSdw (ORCPT ); Sat, 21 Mar 2020 14:33:52 -0400 Received: from sauhun.de ([88.99.104.3]:38110 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727028AbgCUSdw (ORCPT ); Sat, 21 Mar 2020 14:33:52 -0400 Received: from localhost (p54B33C59.dip0.t-ipconnect.de [84.179.60.89]) by pokefinder.org (Postfix) with ESMTPSA id E797B2C2E9C; Sat, 21 Mar 2020 19:33:49 +0100 (CET) Date: Sat, 21 Mar 2020 19:33:49 +0100 From: Wolfram Sang To: Sergey.Semin@baikalelectronics.ru Cc: Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Serge Semin , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] i2c: designware: Add Baikal-T1 SoC I2C controller support Message-ID: <20200321183349.GC5632@ninjato> References: <20200306131955.12806-1-Sergey.Semin@baikalelectronics.ru> <20200306132348.71E638030793@mail.baikalelectronics.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7qSK/uQB79J36Y4o" Content-Disposition: inline In-Reply-To: <20200306132348.71E638030793@mail.baikalelectronics.ru> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7qSK/uQB79J36Y4o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 06, 2020 at 04:19:58PM +0300, Sergey.Semin@baikalelectronics.ru= wrote: > From: Serge Semin >=20 > A third I2C controller embedded into the Baikal-T1 SoC is also fully > based on the DW APB I2C core, but its registers are indirectly > accessible via "command/data in/data out" trio. There is no difference > other than that. So in order to have that controller supported by the > common DW APB I2C driver we only need to introduce a new flag > ACCESS_INDIRECT and use the access-registers to reach the I2C controller > normal registers space in the dw_readl/dw_writel methods. Currently this > flag is only enabled for the controllers with "be,bt1-i2c" compatible > string. >=20 > Signed-off-by: Serge Semin > Signed-off-by: Alexey Malahov Patches 2,3, and 6 have comments which should be addressed. Patches 4+5 can be dropped when sending next version. --7qSK/uQB79J36Y4o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl52Xg0ACgkQFA3kzBSg KbYNoQ/+IqAHiu0yu6E7vmrFh163UulAWJmyVeL2xt5Umm6AqdBs1yTL6Oy4JB6w 9fMelMGKk4uybuL32UvtviBiNBlqdxPrmkNLfqJ3TkFvg/kSev+HR8QIRPS3WNme UuHz5MCoYPfZK8Pbx8oJsaopI0Ad7/d0uB9MOmatEERHz6jrvQulhm42psN2/icM wufLIsBr803+Ld1VxotTU/15lKfOXsYKhDj3LmiP6iUUtc7K0yQdRcD5KI+3+KZ2 FehsEcizI4YuexDTQrup4Ri6PFj7Tcc8ZXEFXjMYQIuVyYZP50Fs8USKSQcja0e6 Q0er8yM3BRqla5ZoCYQsbXqHYDZh70RxYnj6kOPsYFsjyzR54An0NUG9WERTjCaE DVt0qoOfG6uQnQGX9fgJhzQA5TDlr1xcwxU3A4WS+VNgRuBiG1PI0pFkux9/oesG jFSb0SHLxH9sHE6iH9nhb04hlLxPqiI0esFMtAc8PPW2zaH/ksxa70pc5T3QNJUc poJGFzVxhyI9i0mgnWRYjcITPA5rQqIHAPNxzwNOHvkryDyv1L8dzMey2toJzvUB 0NF0i2II9y5nPt2AWm0ctjdRfmsaikLotwAWLHjNBp+mx+dKpOLtF74D/g/knOKo sU0TkXTi56MjIz05pP6/nvbD+fjeVOUtj4MEyYNH5OIhrQQoibE= =KXuX -----END PGP SIGNATURE----- --7qSK/uQB79J36Y4o--