From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28AC3C4332D for ; Sat, 21 Mar 2020 18:47:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02D102077D for ; Sat, 21 Mar 2020 18:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584816478; bh=2cT5cgTSXrYWRUgqTyPsF3K14RwZy4F0nyDHrnhmO3I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=K5hnyYuTyPOuROH7ZYErEsWqrDV4iKN71qDQ3GXnIzjwvwqYBC59e0ZAANUmO8TgT svuVviA8jbocWGO41xXfQ878PU6J3zwQ/ZrTIqRouLu5kANsZ2QCv1K3yq7uYmOdgk BAttSHsMe76nXyXFno5tbcUXOMgWylLWv0/6CW98= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727817AbgCUSr4 (ORCPT ); Sat, 21 Mar 2020 14:47:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:35028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727262AbgCUSr4 (ORCPT ); Sat, 21 Mar 2020 14:47:56 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DDA9320722; Sat, 21 Mar 2020 18:47:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584816476; bh=2cT5cgTSXrYWRUgqTyPsF3K14RwZy4F0nyDHrnhmO3I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cIvp9hgmq4hqcNeMIIjqkKKRyy2Swlb9i/NFYUNmDmtSXxPFwcZtFoqs1F/cyuK0F y3amug9uWe39nvzBjmzfG7jbanBA2TuWIoyWlpA7GSGURzhYilOCZii41J/xSc1GEg TbMzLAxE0oEPWQ+NmoGSl/CoWu5MRsrEtLAUVYco= Date: Sat, 21 Mar 2020 18:47:51 +0000 From: Jonathan Cameron To: Joe Perches Cc: Nishant Malpani , knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: iio: Drop unnecessary explicit casting Message-ID: <20200321184751.717f1d4d@archlinux> In-Reply-To: References: <20200318100754.25667-1-nish.malpani25@gmail.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 21 Mar 2020 05:26:52 -0700 Joe Perches wrote: > On Wed, 2020-03-18 at 15:37 +0530, Nishant Malpani wrote: > > Provide correct specifiers while printing error logs to discard the use > > of unnecessary explicit casting. > [] > > diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c > [] > > @@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c, > > > > regmap = devm_regmap_init_i2c(i2c, &config); > > if (IS_ERR(regmap)) { > > - dev_err(&i2c->dev, "Failed to register i2c regmap %d\n", > > - (int)PTR_ERR(regmap)); > > + dev_err(&i2c->dev, "Failed to register i2c regmap %ld\n", > > + PTR_ERR(regmap)); > > Another option would be to use %pe to print the error identifier > and not the error number > > etc... > > Indeed that would be even better. I'd missed that one being added to the magic of prink :) Jonathan