Re: [PATCH v7 11/14] KVM: selftests: Introduce after_vcpu_run hook for dirty log test

Peter Xu
2020-03-19T16:37:32Z

On Thu, Mar 19, 2020 at 08:50:05AM +0100, Andrew Jones wrote:
> > static void generate_random_array(uint64_t *guest_array, uint64_t size)
> > {
> > uint64_t i;
> > @@ -261,25 +282,23 @@ static void *vcpu_worker(void *data)
> > struct kvm_vm *vm = data;
> > uint64_t *guest_array;
> > uint64_t pages_count = 0;
> > - struct kvm_run *run;
> > + struct sigaction sigact;
> >
> > - run = vcpu_state(vm, VCPU_ID);
> > + current_vm = vm;
> > + vcpu_fd = vcpu_get_fd(vm, VCPU_ID);
>
> You don't add this call until 13/14, which means bisection is broken.
> Please test the series with 'git rebase -i -x make'.

You're right... I do per-patch test but only for the initial version,
then I test the fixups as standalone changes for latter versions.
This must be a wrongly squashed fixup into the wrong patch. Sorry.

I'll wait for some more time for another repost. Thanks,

--
Peter Xu