From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07D6DC54FCF for ; Sun, 22 Mar 2020 21:16:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9C73206F9 for ; Sun, 22 Mar 2020 21:16:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbgCVVQH (ORCPT ); Sun, 22 Mar 2020 17:16:07 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:58057 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726765AbgCVVQH (ORCPT ); Sun, 22 Mar 2020 17:16:07 -0400 X-Originating-IP: 86.202.105.35 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 89CB8FF803; Sun, 22 Mar 2020 21:16:05 +0000 (UTC) Date: Sun, 22 Mar 2020 22:16:05 +0100 From: Alexandre Belloni To: Keyur Patel Cc: Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: bd70528: Avoid double error messaging when IRQ absent Message-ID: <20200322211605.GF221863@piout.net> References: <20200321180838.12729-1-iamkeyur96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200321180838.12729-1-iamkeyur96@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/03/2020 14:08:37-0400, Keyur Patel wrote: > Since the commit 7723f4c ("driver core: platform: Add an error message > to platform_get_irq*()") platform_get_irq() started issuing an error message. > Thus, there is no need to have the same in the driver. > > Signed-off-by: Keyur Patel > --- > drivers/rtc/rtc-bd70528.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com