From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96557C4332E for ; Mon, 23 Mar 2020 18:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7918E20780 for ; Mon, 23 Mar 2020 18:38:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727911AbgCWSin (ORCPT ); Mon, 23 Mar 2020 14:38:43 -0400 Received: from mga05.intel.com ([192.55.52.43]:4056 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727854AbgCWSij (ORCPT ); Mon, 23 Mar 2020 14:38:39 -0400 IronPort-SDR: BBUrZUaHloqpr93dVpPjlPaOMYCNjlXzDiRHa6impAjhERXagygWx8jt8NKpOWcJHsx7Wuhlfd dxlckur55CZg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 11:38:38 -0700 IronPort-SDR: 1FlYqR1KoeDYH/7vk9o1g1GPHmW8uhLynXsrrIUqkHPjzg1egWVNpjS2QB2+qzMMfys5pu6Sbz gKj10E4UOnuw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,297,1580803200"; d="scan'208";a="445908404" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga005.fm.intel.com with ESMTP; 23 Mar 2020 11:38:35 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jGRy9-00CJWk-6v; Mon, 23 Mar 2020 20:38:37 +0200 Date: Mon, 23 Mar 2020 20:38:37 +0200 From: Andy Shevchenko To: Sergey.Semin@baikalelectronics.ru Cc: Hoan Tran , Linus Walleij , Bartosz Golaszewski , Serge Semin , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , "Enrico Weigelt, metux IT consult" , Allison Randal , Kate Stewart , Thomas Gleixner , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/6] gpio: dwapb: Add debounce reference clock support Message-ID: <20200323183837.GV1922688@smile.fi.intel.com> References: <20200306132505.8D3B88030795@mail.baikalelectronics.ru> <20200323180632.14119-1-Sergey.Semin@baikalelectronics.ru> <20200323180632.14119-6-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200323180632.14119-6-Sergey.Semin@baikalelectronics.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2020 at 09:06:31PM +0300, Sergey.Semin@baikalelectronics.ru wrote: > From: Serge Semin > > Aside from the APB reference clock DW GPIO controller can have a > dedicated clock connected to setup a debounce time interval for > GPIO-based IRQs. Since this functionality is optional the corresponding > clock source is also optional. Due to this lets handle the debounce > clock in the same way as it has been developed for the APB reference > clock, but using the bulk request/enable-disable methods. > + if (err) { > + dev_err(gpio->dev, "Cannot reenable APB/Debounce clocks\n"); > + return err; > + } Yeah, this should be a separate change. Otherwise looks good. Also, did I miss the documentation update (bindings)? -- With Best Regards, Andy Shevchenko