From: "John B. Wyatt IV" <jbwyatt4@gmail.com>
To: outreachy-kernel@googlegroups.com,
Julia Lawall <julia.lawall@inria.fr>,
Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Quentin Deslandes <quentin.deslandes@itdev.co.uk>,
Colin Ian King <colin.king@canonical.com>,
Malcolm Priestley <tvboxspy@gmail.com>,
Oscar Carter <oscar.carter@gmx.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: "John B. Wyatt IV" <jbwyatt4@gmail.com>
Subject: [PATCH 1/2] staging: vt6656: remove unneeded variable: ret
Date: Mon, 23 Mar 2020 23:45:44 -0700 [thread overview]
Message-ID: <20200324064545.1832227-2-jbwyatt4@gmail.com> (raw)
In-Reply-To: <20200324064545.1832227-1-jbwyatt4@gmail.com>
Remove unneeded variable ret; replace with 0 for the return value.
Update function documentation (comment) on the return status as
suggested by Julia Lawall <julia.lawall@inria.fr>.
Issue reported by coccinelle (coccicheck).
Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
---
drivers/staging/vt6656/card.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index dc3ab10eb630..05b57a2489a0 100644
--- a/drivers/staging/vt6656/card.c
+++ b/drivers/staging/vt6656/card.c
@@ -716,13 +716,11 @@ int vnt_radio_power_off(struct vnt_private *priv)
* Out:
* none
*
- * Return Value: true if success; otherwise false
+ * Return Value: 0
*
*/
int vnt_radio_power_on(struct vnt_private *priv)
{
- int ret = 0;
-
vnt_exit_deep_sleep(priv);
vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON);
@@ -741,7 +739,7 @@ int vnt_radio_power_on(struct vnt_private *priv)
vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);
- return ret;
+ return 0;
}
void vnt_set_bss_mode(struct vnt_private *priv)
--
2.25.1
next prev parent reply other threads:[~2020-03-24 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 6:45 [PATCH 0/2] staging: vt6656: change function from always returning 0 to void John B. Wyatt IV
2020-03-24 6:45 ` John B. Wyatt IV [this message]
2020-03-24 10:03 ` [PATCH 1/2] staging: vt6656: remove unneeded variable: ret Quentin Deslandes
2020-03-24 6:45 ` [PATCH 2/2] staging: vt6656: change unused int return value to void John B. Wyatt IV
2020-03-24 17:28 ` [PATCH 0/2] staging: vt6656: change function from always returning 0 " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324064545.1832227-2-jbwyatt4@gmail.com \
--to=jbwyatt4@gmail.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=oscar.carter@gmx.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=quentin.deslandes@itdev.co.uk \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox