From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81329C4332B for ; Tue, 24 Mar 2020 09:53:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47DCA2070A for ; Tue, 24 Mar 2020 09:53:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ymf3ZauZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727234AbgCXJxK (ORCPT ); Tue, 24 Mar 2020 05:53:10 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:57674 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727095AbgCXJxJ (ORCPT ); Tue, 24 Mar 2020 05:53:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585043588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Gq/lKW8WyRYl5edQacpGKYdDQGdtrGN/tjzEhNXWjEE=; b=Ymf3ZauZeKeJI9EYn13x3WJZLgKHbm6rtNLIMwfgM4Hb0byakD51dOGYeFcQVcODhf3bzj /SFfRB/uCiZenykekst5bNfp+mza85szjQupR8WRuoXVuEnzmP1kzysDHIydjUjTusxtA/ fD5+gtjDXlMyFoPqpmFq8JueEiQDC9A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-62-KZrYVp3gNL-ikeQcra1K_w-1; Tue, 24 Mar 2020 05:53:04 -0400 X-MC-Unique: KZrYVp3gNL-ikeQcra1K_w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ED4268017CC; Tue, 24 Mar 2020 09:53:02 +0000 (UTC) Received: from asgard.redhat.com (unknown [10.36.110.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9ECE91001B3F; Tue, 24 Mar 2020 09:52:59 +0000 (UTC) Date: Tue, 24 Mar 2020 10:53:04 +0100 From: Eugene Syromiatnikov To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Pratik Patel , Maxime Coquelin , Alexandre Torgue , Michael Williams , Mathieu Poirier , Chunyan Zhang , "Dmitry V. Levin" Subject: Re: [PATCH] coresight: do not use the BIT() macro in the UAPI header Message-ID: <20200324095304.GA2444@asgard.redhat.com> References: <20200324042213.GA10452@asgard.redhat.com> <20200324062853.GD1977781@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324062853.GD1977781@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2020 at 07:28:53AM +0100, Greg Kroah-Hartman wrote: > On Tue, Mar 24, 2020 at 05:22:13AM +0100, Eugene Syromiatnikov wrote: > > The BIT() macro definition is not available for the UAPI headers > > (moreover, it can be defined differently in the user space); replace > > its usage with the _BITUL() macro that is defined in . > > Why is somehow _BITUL() ok to use here instead? It is provided in an UAPI header (include/uapi/linux/const.h) and is appropriately prefixed with an underscore to avoid conflicts. > Just open-code it, I didn't think we could use any BIT()-like macros in > uapi .h files. > > thanks, > > greg k-h >