From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFC25C43331 for ; Tue, 24 Mar 2020 13:14:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99EA9206F6 for ; Tue, 24 Mar 2020 13:14:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585055683; bh=sykPMuL8ZVroeZa9PtA63mp+y+kwPtLXdFQ381aVP8A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=aoD3H8ghqtY8+rvQfkIGM338Tsonh8TTTaKjsMX03u+IF9ItntopH56vJ+uIpZhNL CKqUCXskzAT74MhvYhU5yqze/NS0oPhvXEupzZsu2J3lEaj9LG+6Bz3cBPZTEP+WCJ BbhE1FGMf11b1FZe5pGl7H7BNmyvrtB8GhI4DagQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728129AbgCXNOm (ORCPT ); Tue, 24 Mar 2020 09:14:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:33138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727570AbgCXNOj (ORCPT ); Tue, 24 Mar 2020 09:14:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 644DB208D5; Tue, 24 Mar 2020 13:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585055678; bh=sykPMuL8ZVroeZa9PtA63mp+y+kwPtLXdFQ381aVP8A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gGYtQprT0QnCZwhXkRerdbLLUg+2PmEKxWvtqPEllnIEUBHuMBVJwPsK5oxwKbrsl m902wHEekeQvxY9gjd0IXjFYxvijP1OzjjmyTEmFUwQ/J7719s0aAS5YcNF/rcppdk m7YFRewvF9zTyjM1GxCes1XC2VEkBoOWl/tHIZUE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kai-Heng Feng , Takashi Iwai Subject: [PATCH 4.19 60/65] ALSA: hda/realtek: Fix pop noise on ALC225 Date: Tue, 24 Mar 2020 14:11:21 +0100 Message-Id: <20200324130804.238050795@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200324130756.679112147@linuxfoundation.org> References: <20200324130756.679112147@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kai-Heng Feng commit 3b36b13d5e69d6f51ff1c55d1b404a74646c9757 upstream. Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0") makes the ALC225 have pop noise on S3 resume and cold boot. So partially revert this commit for ALC225 to fix the regression. Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0") BugLink: https://bugs.launchpad.net/bugs/1866357 Signed-off-by: Kai-Heng Feng Link: https://lore.kernel.org/r/20200311061328.17614-1-kai.heng.feng@canonical.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_realtek.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7828,6 +7828,8 @@ static int patch_alc269(struct hda_codec spec->gen.mixer_nid = 0; break; case 0x10ec0225: + codec->power_save_node = 1; + /* fall through */ case 0x10ec0295: case 0x10ec0299: spec->codec_variant = ALC269_TYPE_ALC225;