public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	andreyknvl@google.com, aryabinin@virtuozzo.com
Subject: Re: linux-next: Tree for Mar 20 (objtool warnings)
Date: Tue, 24 Mar 2020 22:13:03 +0100	[thread overview]
Message-ID: <20200324211303.GQ2452@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <39035493-9d5b-9da3-10d4-0af5d1cdb32a@infradead.org>

On Tue, Mar 24, 2020 at 10:53:05AM -0700, Randy Dunlap wrote:
> >> kernel/kcov.o: warning: objtool: __sanitizer_cov_trace_pc()+0x89: call to __ubsan_handle_load_invalid_value() with UACCESS enabled
> >>
> 
> config-r1510 is attached.
> and kcov.o is attached.

I'm thinking this is because of commit:

  0d6958a70483 kcov: collect coverage from interrupts

Which has:

@@ -1230,6 +1230,9 @@ struct task_struct {

+       bool                            kcov_softirq;

@@ -145,9 +157,10 @@ static notrace bool check_kcov_mode(enum kcov_mode needed_mode, struct task_stru

+       if (!in_task() && !(in_serving_softirq() && t->kcov_softirq))

And this __ubsan_handle_load_invalid_value() is verifying a bool is 0,1.

Another reason to hate on _Bool I suppose...

Let me see what to do about that... :/

  reply	other threads:[~2020-03-24 21:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20  9:15 linux-next: Tree for Mar 20 Stephen Rothwell
2020-03-20 16:11 ` linux-next: Tree for Mar 20 (drivers/media/i2c/video-i2c.o) Randy Dunlap
2020-03-21  7:02   ` Matt Ranostay
2020-03-20 17:43 ` linux-next: Tree for Mar 20 (objtool warnings) Randy Dunlap
2020-03-24 16:47   ` Josh Poimboeuf
2020-03-24 17:53     ` Randy Dunlap
2020-03-24 21:13       ` Peter Zijlstra [this message]
2020-03-24 23:02         ` Andrey Konovalov
2020-03-26 14:45         ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200324211303.GQ2452@worktop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=andreyknvl@google.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox