Re: [PATCH v5] dt-bindings: mfd: Convert stpmic1 bindings to json-schema

Lee Jones
2020-03-25T09:19:19Z

On Tue, 10 Mar 2020, Rob Herring wrote:

> On Wed, 4 Mar 2020 10:42:20 +0100, Benjamin Gaignard wrote:
> > Convert stpmic1 bindings to json-schema.
> >
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> > ---
> > version 5:
> > - move $ref regulator.yaml under a patternProperties
> > - move remain fixed strings under properties field
> >
> > version 4:
> > - move on uppder node $ref: ../regulator/regulator.yaml
> > - move fixed strings under properties field
> > - remove unneeded () in patternProperties
> > - keep ldo3 separate from other ldo properties
> > Note:
> > - 'st,mask-reset' property stay in each subnode, I don't find
> > the syntax to avoid dupliquate it.
> > - ldo6-supply and all possible *-supply are describe by this regular
> > expression: ^(buck[1-4]|ldo[1-6]|boost|pwr_sw[1-2])-supply$":
> >
> > version 3:
> > - put $ref under allOf keyword
> > - for each regulator node add the list of supported regulator properties
> >
> > .../devicetree/bindings/input/st,stpmic1-onkey.txt | 28 --
> > .../devicetree/bindings/mfd/st,stpmic1.txt | 61 ----
> > .../devicetree/bindings/mfd/st,stpmic1.yaml | 339 +++++++++++++++++++++
> > .../bindings/regulator/st,stpmic1-regulator.txt | 64 ----
> > .../bindings/watchdog/st,stpmic1-wdt.txt | 11 -
> > 5 files changed, 339 insertions(+), 164 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/input/st,stpmic1-onkey.txt
> > delete mode 100644 Documentation/devicetree/bindings/mfd/st,stpmic1.txt
> > create mode 100644 Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> > delete mode 100644 Documentation/devicetree/bindings/regulator/st,stpmic1-regulator.txt
> > delete mode 100644 Documentation/devicetree/bindings/watchdog/st,stpmic1-wdt.txt
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>

Can you take this please Rob?

It would save an IB and PR.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog