From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Sam Lunt <samueljlunt@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
He Zhe <zhe.he@windriver.com>, Jiri Olsa <jolsa@redhat.com>,
peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] perf: Be compatible with all python versions when fetching ldflags
Date: Wed, 25 Mar 2020 16:26:40 -0300 [thread overview]
Message-ID: <20200325192640.GI14102@kernel.org> (raw)
In-Reply-To: <CAGn10uVQdP32PNqyBm_dCxvRisj5tw4GU1f8j6Rq=Q6bmjmaAw@mail.gmail.com>
Em Wed, Mar 25, 2020 at 09:40:34AM -0500, Sam Lunt escreveu:
> On Wed, Mar 25, 2020 at 8:30 AM Arnaldo Carvalho de Melo
> <arnaldo.melo@gmail.com> wrote:
> >
> > Em Mon, Feb 17, 2020 at 10:24:27AM +0800, He Zhe escreveu:
> > >
> > >
> > > On 2/17/20 6:22 AM, Jiri Olsa wrote:
> > > > On Fri, Feb 14, 2020 at 02:21:05AM +0800, zhe.he@windriver.com wrote:
> > > >> From: He Zhe <zhe.he@windriver.com>
> > > >>
> > > >> Since Python v3.8.0, with the following commit
> > > >> 0a8e57248b91 ("bpo-36721: Add --embed option to python-config (GH-13500)"),
> > > > we got similar change recently.. might have not been picked up yet
> > > >
> > > > https://lore.kernel.org/lkml/20200131181123.tmamivhq4b7uqasr@gmail.com/
> > >
> > > Thanks for pointing out.
> >
> > So, just with your patch:
> >
> > [acme@five perf]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf
> > [acme@five perf]$ make PYTHON=python3 -C tools/perf O=/tmp/build/perf install-bin |& grep python
> > ... libpython: [ OFF ]
> > Makefile.config:750: No 'Python.h' (for Python 2.x support) was found: disables Python support - please install python-devel/python-dev
> > CC /tmp/build/perf/tests/python-use.o
> > [acme@five perf]$
> >
> > [acme@five perf]$ rpm -q python2-devel python3-devel python-devel
> > package python2-devel is not installed
> > python3-devel-3.7.6-2.fc31.x86_64
> > package python-devel is not installed
> > [acme@five perf]$
> >
> > [acme@five perf]$ cat /tmp/build/perf/feature/test-libpython.make.output
> > /bin/sh: --configdir: command not found
> > [acme@five perf]$ cat /tmp/build/perf/feature/test-libpython
> > test-libpython.make.output test-libpython-version.make.output
> > [acme@five perf]$ cat /tmp/build/perf/feature/test-libpython-version.make.output
> > /bin/sh: --configdir: command not found
> > [acme@five perf]$
> >
> >
> > Without your patch:
> >
> > [acme@five perf]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf
> > [acme@five perf]$ make PYTHON=python3 -C tools/perf O=/tmp/build/perf install-bin |& grep python
> > ... libpython: [ on ]
> > GEN /tmp/build/perf/python/perf.so
> > MKDIR /tmp/build/perf/scripts/python/Perf-Trace-Util/
> > CC /tmp/build/perf/scripts/python/Perf-Trace-Util/Context.o
> > LD /tmp/build/perf/scripts/python/Perf-Trace-Util/perf-in.o
> > CC /tmp/build/perf/tests/python-use.o
> > CC /tmp/build/perf/util/scripting-engines/trace-event-python.o
> > INSTALL python-scripts
> > [acme@five perf]$
> >
> > [acme@five perf]$ ldd /tmp/build/perf/perf |& grep python
> > libpython3.7m.so.1.0 => /lib64/libpython3.7m.so.1.0 (0x00007f11dd1ee000)
> > [acme@five perf]$ perf -vv |& grep -i python
> > libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT
> > [acme@five perf]$
> >
> > What am I missing?
>
> It looks like you are using python3.7, but the change in behavior for
> python-config happened in version 3.8
Humm, but shouldn't this continue to work with python3.7?
- Arnaldo
> > [acme@five perf]$ cat /etc/redhat-release
> > Fedora release 31 (Thirty One)
> > [acme@five perf]$
> >
> > - Arnaldo
--
- Arnaldo
next prev parent reply other threads:[~2020-03-25 19:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 18:21 [PATCH 1/2] perf: Be compatible with all python versions when fetching ldflags zhe.he
2020-02-13 18:21 ` [PATCH 2/2] perf: Normalize gcc parameter when generating arch errno table zhe.he
2020-03-25 13:05 ` He Zhe
2020-04-04 8:41 ` [tip: perf/urgent] " tip-bot2 for He Zhe
2020-02-16 22:22 ` [PATCH 1/2] perf: Be compatible with all python versions when fetching ldflags Jiri Olsa
2020-02-17 2:24 ` He Zhe
2020-03-25 13:30 ` Arnaldo Carvalho de Melo
2020-03-25 14:40 ` Sam Lunt
2020-03-25 19:26 ` Arnaldo Carvalho de Melo [this message]
2020-03-25 20:31 ` Sam Lunt
2020-03-26 1:06 ` Arnaldo Melo
2020-03-26 10:33 ` He Zhe
2020-04-04 8:41 ` [tip: perf/urgent] perf tools: Support Python 3.8+ in Makefile tip-bot2 for Sam Lunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325192640.GI14102@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=samueljlunt@gmail.com \
--cc=zhe.he@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox