From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org,
Collabora Kernel ML <kernel@collabora.com>,
Andrzej Hajda <a.hajda@samsung.com>,
icenowy@aosc.io, anarsoul@gmail.com,
Neil Armstrong <narmstrong@baylibre.com>,
matthias.bgg@gmail.com, drinkcat@chromium.org,
hsinyi@chromium.org, megous@megous.com
Subject: Re: [PATCH v4 2/4] mfd: anx7688: Add driver for Analogix ANX7688 chip
Date: Thu, 26 Mar 2020 09:30:19 +0000 [thread overview]
Message-ID: <20200326093019.GC603801@dell> (raw)
In-Reply-To: <20200318070730.4012371-2-enric.balletbo@collabora.com>
On Wed, 18 Mar 2020, Enric Balletbo i Serra wrote:
> The ANX7688 chip is a Type-C Port Controller, HDMI to DP converter and
> USB-C mux between USB 3.0 lanes and the DP output.
>
> For our use case a big part of the chip, like power supplies, control
> gpios and usb-c parts are managed by an Embedded Controller, hence,
> this is its simplest form of it. Other users of this chip might
> introduce new functionalities as per their requirements.
Hmm... So first impressions is that this 'driver' doesn't really do
anything useful other than checking the running model. I think you're
better off using "simple-mfd" and doing the ID check inside the
useful/functional child device driver(s).
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> drivers/mfd/Kconfig | 11 +++++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/anx7688.c | 87 +++++++++++++++++++++++++++++++++++++
> include/linux/mfd/anx7688.h | 39 +++++++++++++++++
> 4 files changed, 138 insertions(+)
> create mode 100644 drivers/mfd/anx7688.c
> create mode 100644 include/linux/mfd/anx7688.h
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-03-26 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 7:07 [PATCH v4 1/4] dt-bindings: Add binding for the Analogix ANX7688 chip Enric Balletbo i Serra
2020-03-18 7:07 ` [PATCH v4 2/4] mfd: anx7688: Add driver for " Enric Balletbo i Serra
2020-03-26 9:30 ` Lee Jones [this message]
2020-03-18 7:07 ` [PATCH v4 3/4] dt-bindings: Add ANX7688 HDMI to DP bridge binding Enric Balletbo i Serra
2020-03-18 7:07 ` [PATCH v4 4/4] drm/bridge: anx7688: Add ANX7688 bridge driver support Enric Balletbo i Serra
2020-03-30 22:58 ` [PATCH v4 1/4] dt-bindings: Add binding for the Analogix ANX7688 chip Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326093019.GC603801@dell \
--to=lee.jones@linaro.org \
--cc=a.hajda@samsung.com \
--cc=anarsoul@gmail.com \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=icenowy@aosc.io \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=megous@megous.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox