public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Hagen Paul Pfeifer <hagen@jauu.net>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] perf script: introduce deltatime option
Date: Thu, 26 Mar 2020 11:33:55 -0300	[thread overview]
Message-ID: <20200326143355.GB6411@kernel.org> (raw)
In-Reply-To: <20200204173709.489161-1-hagen@jauu.net>

Em Tue, Feb 04, 2020 at 06:37:09PM +0100, Hagen Paul Pfeifer escreveu:
> For some kind of analysis a deltatime output is more human friendly and reduce
> the cognitive load for further analysis.
> 
> The following output demonstrate the new option "deltatime": calculate
> the time difference in relation to the previous event.
> 
> $ perf script --deltatime
> test  2525 [001]     0.000000:            sdt_libev:ev_add: (5635e72a5ebd)
> test  2525 [001]     0.000091:  sdt_libev:epoll_wait_enter: (5635e72a76a9)
> test  2525 [001]     1.000051: sdt_libev:epoll_wait_return: (5635e72a772e) arg1=1
> test  2525 [001]     0.000685:            sdt_libev:ev_add: (5635e72a5ebd)
> test  2525 [001]     0.000048:  sdt_libev:epoll_wait_enter: (5635e72a76a9)
> test  2525 [001]     1.000104: sdt_libev:epoll_wait_return: (5635e72a772e) arg1=1
> test  2525 [001]     0.003895:  sdt_libev:epoll_wait_enter: (5635e72a76a9)
> test  2525 [001]     0.996034: sdt_libev:epoll_wait_return: (5635e72a772e) arg1=1
> test  2525 [001]     0.000058:  sdt_libev:epoll_wait_enter: (5635e72a76a9)
> test  2525 [001]     1.000004: sdt_libev:epoll_wait_return: (5635e72a772e) arg1=1
> test  2525 [001]     0.000064:  sdt_libev:epoll_wait_enter: (5635e72a76a9)
> test  2525 [001]     0.999934: sdt_libev:epoll_wait_return: (5635e72a772e) arg1=1
> test  2525 [001]     0.000056:  sdt_libev:epoll_wait_enter: (5635e72a76a9)
> test  2525 [001]     0.999930: sdt_libev:epoll_wait_return: (5635e72a772e) arg1=1

You forgot to update the man page, I did it, tested and applied, thanks.

- Arnaldo

diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt
index db6a36aac47e..4af255bb0977 100644
--- a/tools/perf/Documentation/perf-script.txt
+++ b/tools/perf/Documentation/perf-script.txt
@@ -390,6 +390,9 @@ include::itrace.txt[]
 --reltime::
 	Print time stamps relative to trace start.
 
+--deltatime::
+	Print time stamps relative to previous event.
+
 --per-event-dump::
 	Create per event files with a "perf.data.EVENT.dump" name instead of
         printing to stdout, useful, for instance, for generating flamegraphs.

  parent reply	other threads:[~2020-03-26 14:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04 17:37 [PATCH] perf script: introduce deltatime option Hagen Paul Pfeifer
2020-02-04 23:16 ` Andi Kleen
2020-02-05  9:14   ` Hagen Paul Pfeifer
2020-02-05 17:22     ` Andi Kleen
2020-03-26 14:33 ` Arnaldo Carvalho de Melo [this message]
2020-04-04  8:41 ` [tip: perf/urgent] perf script: Introduce --deltatime option tip-bot2 for Hagen Paul Pfeifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200326143355.GB6411@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=hagen@jauu.net \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox