From: Jessica Yu <jeyu@kernel.org>
To: David Laight <David.Laight@aculab.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
'Linus Torvalds' <torvalds@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Matthias Maennich <maennich@google.com>
Subject: Re: modpost Module.symver handling is broken in 5.6.0-rc7
Date: Thu, 26 Mar 2020 18:14:53 +0100 [thread overview]
Message-ID: <20200326171453.GA21406@linux-8ccs> (raw)
In-Reply-To: <90b763cc306140499fddf8e3185e26f5@AcuMS.aculab.com>
+++ David Laight [26/03/20 17:06 +0000]:
>From: Jessica Yu
>> Sent: 26 March 2020 16:51
>> +++ David Laight [26/03/20 16:25 +0000]:
>> >Something is currently broken in modpost.
>> >I'm guessing it is down to the recent patch that moved the
>> >namespace back to the end of the line.
>> >
>> >I'm building 2 'out of tree' modules that have a symbol dependency.
>> >When I build the 2nd module I get ERROR "symbol" undefined message.
>> >
>> >If I flip the order of the fields in Module.symver to the older order
>> >and link with modpost from 5.4.0-rc7 (which I happen to have lurking)
>> >it all works fine.
>> >
>> >Note that I'm using a named namespace, not the default one
>> >that is the full path of the module.
>> >
>> >I'll dig in a little further.
>>
>> [ Adding more people to CC ]
>>
>> Hi David,
>>
>> Could you provide some more details about how I can reproduce the
>> issue? As I understand it, you have two out-of-tree modules, and one
>> has a symbol dependency on the second? Pasting the modpost error
>> messages helps too.
>
>Ok, I've found out what broke it.
>Was actually the removal of the code that parsed Module.symvers
>from the current directory (which happened for 5.5.0-rc0).
>
>Took some digging and printfs in modpost to find what wasn't happening.
>
> David
Hi David,
I'm a bit confused - just to confirm, is there a legitimate bug
upstream or was it just a hiccup related to your setup?
Thanks!
Jessica
next prev parent reply other threads:[~2020-03-26 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 16:25 modpost Module.symver handling is broken in 5.6.0-rc7 David Laight
2020-03-26 16:50 ` Jessica Yu
2020-03-26 17:06 ` David Laight
2020-03-26 17:14 ` Jessica Yu [this message]
2020-03-26 17:34 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326171453.GA21406@linux-8ccs \
--to=jeyu@kernel.org \
--cc=David.Laight@aculab.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maennich@google.com \
--cc=masahiroy@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox