Re: [PATCH v4 1/5] dt-bindings: mfd: add document bindings for mp2629

Lee Jones
2020-03-27T07:59:26Z

On Sun, 22 Mar 2020, Saravanan Sekar wrote:

> Add device tree binding information for mp2629 mfd driver.
>
> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
> ---
> .../devicetree/bindings/mfd/mps,mp2629.yaml | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
> new file mode 100644
> index 000000000000..314309ea91ac
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/mps,mp2629.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#

Are these links supposed to work?

> +title: MP2629 Battery Charger PMIC from Monolithic Power System.
> +
> +maintainers:
> + - Saravanan Sekar <sravanhome@gmail.com>
> +
> +description: |
> + MP2629 is an PMIC providing battery charging and power supply for smartphones,

s/an/a/

> + wireless camera and portable devices. Chip is contrlled over I2C.

Spell check!

> + The MFD device handles battery charger controller and ADC IIO device for
> + battery, system voltage

MFD isn't a thing. We made it up. Please describe it as it is in the datasheet.

> +properties:
> + compatible:
> + const: mps,mp2629
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 2
> + description:
> + The first cell is the IRQ number, the second cell is the trigger type.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-controller
> + - "#interrupt-cells"
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/input/linux-event-codes.h>
> + i2c {

i2c@0x????????

> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@4b {
> + compatible = "mps,mp2629";
> + reg = <0x4b>;
> +
> + interrupt-controller;
> + interrupt-parent = <&gpio2>;
> + #interrupt-cells = <2>;
> + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
> + };
> + };

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog