From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D162EC2D0ED for ; Fri, 27 Mar 2020 17:23:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B392A206DB for ; Fri, 27 Mar 2020 17:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727800AbgC0RXG (ORCPT ); Fri, 27 Mar 2020 13:23:06 -0400 Received: from mga01.intel.com ([192.55.52.88]:9882 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727754AbgC0RXG (ORCPT ); Fri, 27 Mar 2020 13:23:06 -0400 IronPort-SDR: +Gyo2xhleGpUOVeHuam5UP8Z+kRFblCLaFI4ilA4wrB98JREZTFlTKQdSO9IfMUdqNScJSr0z/ ORi4iJ/yDz1w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2020 10:23:05 -0700 IronPort-SDR: dmCESq+UuI/tUr1+5McIjHKVJAkla5rxQ82hDDoulRwum86+9trA9MXHYN3YnNUG5mZ/Lfejpc IxZbe8txAaow== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,313,1580803200"; d="scan'208";a="394441624" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga004.jf.intel.com with ESMTP; 27 Mar 2020 10:23:05 -0700 Date: Fri, 27 Mar 2020 10:28:50 -0700 From: Jacob Pan To: "Tian, Kevin" Cc: Joerg Roedel , Alex Williamson , Lu Baolu , "iommu@lists.linux-foundation.org" , LKML , David Woodhouse , Jean-Philippe Brucker , "Liu, Yi L" , "Raj, Ashok" , Christoph Hellwig , Jonathan Cameron , Eric Auger , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH 05/10] iommu/ioasid: Create an IOASID set for host SVA use Message-ID: <20200327102850.77a5d5da@jacob-builder> In-Reply-To: References: <1585158931-1825-1-git-send-email-jacob.jun.pan@linux.intel.com> <1585158931-1825-6-git-send-email-jacob.jun.pan@linux.intel.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Mar 2020 09:41:55 +0000 "Tian, Kevin" wrote: > > From: Jacob Pan > > Sent: Thursday, March 26, 2020 1:55 AM > > > > Bare metal SVA allocates IOASIDs for native process addresses. This > > should be separated from VM allocated IOASIDs thus under its own > > set. > > A curious question. Now bare metal SVA uses the system set and guest > SVA uses dynamically-created set. Then do we still allow ioasid_alloc > with a NULL set pointer? > Good point! There shouldn't be NULL set. That was one of the sticky point in the previous allocation API. I will add a check in ioasid_alloc_set(). However, there is still need for global search, e.g. PRS. https://lore.kernel.org/linux-arm-kernel/1d62b2e1-fe8c-066d-34e0-f7929f6a78e2@arm.com/#t In that case, use INVALID_IOASID_SET to indicate the search is global. e.g. ioasid_find(INVALID_IOASID_SET, data->hpasid, NULL); > > > > This patch creates a system IOASID set with its quota set to > > PID_MAX. This is a reasonable default in that SVM capable devices > > can only bind to limited user processes. > > > > Signed-off-by: Jacob Pan > > --- > > drivers/iommu/intel-iommu.c | 8 +++++++- > > drivers/iommu/ioasid.c | 9 +++++++++ > > include/linux/ioasid.h | 9 +++++++++ > > 3 files changed, 25 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/intel-iommu.c > > b/drivers/iommu/intel-iommu.c index ec3fc121744a..af7a1ef7b31e > > 100644 --- a/drivers/iommu/intel-iommu.c > > +++ b/drivers/iommu/intel-iommu.c > > @@ -3511,8 +3511,14 @@ static int __init init_dmars(void) > > goto free_iommu; > > > > /* PASID is needed for scalable mode irrespective to SVM */ > > - if (intel_iommu_sm) > > + if (intel_iommu_sm) { > > ioasid_install_capacity(intel_pasid_max_id); > > + /* We should not run out of IOASIDs at boot */ > > + if (ioasid_alloc_system_set(PID_MAX_DEFAULT)) { > > + pr_err("Failed to enable host PASID > > allocator\n"); > > + intel_iommu_sm = 0; > > + } > > + } > > > > /* > > * for each drhd > > diff --git a/drivers/iommu/ioasid.c b/drivers/iommu/ioasid.c > > index 6265d2dbbced..9135af171a7c 100644 > > --- a/drivers/iommu/ioasid.c > > +++ b/drivers/iommu/ioasid.c > > @@ -39,6 +39,9 @@ struct ioasid_data { > > static ioasid_t ioasid_capacity; > > static ioasid_t ioasid_capacity_avail; > > > > +int system_ioasid_sid; > > +static DECLARE_IOASID_SET(system_ioasid); > > + > > /* System capacity can only be set once */ > > void ioasid_install_capacity(ioasid_t total) > > { > > @@ -51,6 +54,12 @@ void ioasid_install_capacity(ioasid_t total) > > } > > EXPORT_SYMBOL_GPL(ioasid_install_capacity); > > > > +int ioasid_alloc_system_set(int quota) > > +{ > > + return ioasid_alloc_set(&system_ioasid, quota, > > &system_ioasid_sid); +} > > +EXPORT_SYMBOL_GPL(ioasid_alloc_system_set); > > + > > /* > > * struct ioasid_allocator_data - Internal data structure to hold > > information > > * about an allocator. There are two types of allocators: > > diff --git a/include/linux/ioasid.h b/include/linux/ioasid.h > > index 8c82d2625671..097b1cc043a3 100644 > > --- a/include/linux/ioasid.h > > +++ b/include/linux/ioasid.h > > @@ -29,6 +29,9 @@ struct ioasid_allocator_ops { > > void *pdata; > > }; > > > > +/* Shared IOASID set for reserved for host system use */ > > +extern int system_ioasid_sid; > > + > > #define DECLARE_IOASID_SET(name) struct ioasid_set name = { 0 } > > > > #if IS_ENABLED(CONFIG_IOASID) > > @@ -41,6 +44,7 @@ int ioasid_register_allocator(struct > > ioasid_allocator_ops *allocator); > > void ioasid_unregister_allocator(struct ioasid_allocator_ops > > *allocator); int ioasid_attach_data(ioasid_t ioasid, void *data); > > void ioasid_install_capacity(ioasid_t total); > > +int ioasid_alloc_system_set(int quota); > > int ioasid_alloc_set(struct ioasid_set *token, ioasid_t quota, int > > *sid); void ioasid_free_set(int sid, bool destroy_set); > > int ioasid_find_sid(ioasid_t ioasid); > > @@ -88,5 +92,10 @@ static inline void > > ioasid_install_capacity(ioasid_t total) { > > } > > > > +static inline int ioasid_alloc_system_set(int quota) > > +{ > > + return -ENOTSUPP; > > +} > > + > > #endif /* CONFIG_IOASID */ > > #endif /* __LINUX_IOASID_H */ > > -- > > 2.7.4 > [Jacob Pan]