From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7169C2D0E5 for ; Fri, 27 Mar 2020 11:48:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C507D206E6 for ; Fri, 27 Mar 2020 11:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727242AbgC0LsH (ORCPT ); Fri, 27 Mar 2020 07:48:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:52594 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbgC0LsH (ORCPT ); Fri, 27 Mar 2020 07:48:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A1E52AB7F; Fri, 27 Mar 2020 11:48:05 +0000 (UTC) Date: Fri, 27 Mar 2020 11:48:01 +0000 From: Mel Gorman To: Aubrey Li Cc: vincent.guittot@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com, vpillai@digitalocean.com, joel@joelfernandes.org, Aubrey Li , Phil Auld Subject: Re: [PATCH] sched/fair: Fix negative imbalance in imbalance calculation Message-ID: <20200327114801.GL3772@suse.de> References: <1585201349-70192-1-git-send-email-aubrey.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1585201349-70192-1-git-send-email-aubrey.li@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2020 at 01:42:29PM +0800, Aubrey Li wrote: > A negative imbalance value was observed after imbalance calculation, > this happens when the local sched group type is group_fully_busy, > and the average load of local group is greater than the selected > busiest group. Fix this problem by comparing the average load of the > local and busiest group before imbalance calculation formula. > > Suggested-by: Vincent Guittot > Signed-off-by: Aubrey Li > Cc: Phil Auld Acked-by: Mel Gorman -- Mel Gorman SUSE Labs