Re: [PATCH v2 17/22] memory: tegra30-emc: Register as interconnect provider

Dmitry Osipenko
2020-04-13T15:18:11Z

13.04.2020 15:44, Georgi Djakov пишет:
...
> All the above seems like a duplicate of what we already have in the previous
> patch for tegra20-emc. Can we have a single driver for both? Maybe extract the
> above as a separate interconnect provider driver.

Perhaps we could do it later on, once the work on the drivers will
settle down. I think it should be okay to have some minor duplication
for now, we already have some other small things duplicated in these
drivers.

>> static int tegra_emc_probe(struct platform_device *pdev)
>> {
>> struct platform_device *mc;
>> @@ -1344,6 +1452,13 @@ static int tegra_emc_probe(struct platform_device *pdev)
>> platform_set_drvdata(pdev, emc);
>> tegra_emc_debugfs_init(emc);
>>
>> + if (IS_ENABLED(CONFIG_INTERCONNECT)) {
>> + err = tegra_emc_interconnect_init(emc);
>
> How about registering a platform device that will use the same driver to handle
> the interconnect functionality for both tegra20 and tegra30?

It should be possible. But it also should be possible to make all these
drivers modular, which I'm going to try out.