Re: [PATCH 1/3] kernel/sysctl: support setting sysctl parameters from kernel command line

Kees Cook
2020-04-06T15:58:56Z

On Mon, Apr 06, 2020 at 02:08:36PM +0000, Luis Chamberlain wrote:
> > Yes. Doing an internal extension isn't testing the actual code.
>
> But it would.
>
> [...]
> > I don't think anything is needed for this series. It can be boot tested
> > manually.
>
> Why test it manually when it could be tested automatically with a new kconfig?

So, my impression is that adding code to the internals to test the
internals isn't a valid test (or at least makes it fragile) because the
test would depend on the changes to the internals (or at least depend on
non-default non-production CONFIGs).

Can you send a patch for what you think this should look like? Perhaps
I'm not correctly imagining what you're describing?

Regardless of testing, I think this series is ready for -mm.

--
Kees Cook