public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Xiaoming Ni <nixiaoming@huawei.com>
Cc: <richard@nod.at>, <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<wangle6@huawei.com>, <zhangweimin12@huawei.com>,
	<yebin10@huawei.com>, <houtao1@huawei.com>
Subject: Re: [PATCH] mtd:clear cache_state to avoid writing to bad clocks repeatedly
Date: Mon, 30 Mar 2020 10:47:41 +0200	[thread overview]
Message-ID: <20200330104741.2f48378d@xps13> (raw)
In-Reply-To: <a012c55f-e7c4-fd6d-3e3f-f132474a0b06@huawei.com>

Hi Xiaoming,

Xiaoming Ni <nixiaoming@huawei.com> wrote on Mon, 30 Mar 2020 16:44:29
+0800:

> On 2020/3/30 15:53, Miquel Raynal wrote:
> > Hi Xiaoming,
> > 
> > Xiaoming Ni <nixiaoming@huawei.com> wrote on Sat, 28 Mar 2020 21:01:17
> > +0800:
> >   
> >> The function call process is as follows:
> >> 	mtd_blktrans_work()
> >> 	  while (1)  
> ....
> 
> >> +	 *
> >> +	 * if this cache_offset points to a bad block  
> > 
> > Can you start your sentences with a capital letter please?
> > 
> > 	 * If
> >   
> >> +	 * data cannot be written to the device.
> >> +	 * clear cache_state to avoid writing to bad clocks repeatedly  
> > 
> > 	 * Clear
> > 
> > And also please break your lines à 80, not 70.
> >   
> >>   	 */
> >> -	mtdblk->cache_state = STATE_EMPTY;
> >> -	return 0;
> >> +	if (ret == 0 || ret == -EIO)
> >> +		mtdblk->cache_state = STATE_EMPTY;  
> Should I add a warning print for EIO here

I don't think so.

Thanks,
Miquèl

  reply	other threads:[~2020-03-30  8:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-28 13:01 [PATCH] mtd:clear cache_state to avoid writing to bad clocks repeatedly Xiaoming Ni
2020-03-30  7:53 ` Miquel Raynal
2020-03-30  8:44   ` Xiaoming Ni
2020-03-30  8:47     ` Miquel Raynal [this message]
2020-03-30  7:54 ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200330104741.2f48378d@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=houtao1@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nixiaoming@huawei.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=wangle6@huawei.com \
    --cc=yebin10@huawei.com \
    --cc=zhangweimin12@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox