Re: [PATCH v10 2/9] proc: allow to mount many instances of proc in one pid namespace

Alexey Gladkov
2020-04-02T16:33:27Z

On Thu, Apr 02, 2020 at 10:31:48AM -0500, Eric W. Biederman wrote:
>
> > diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h
> > index 40a7982b7285..5920a4ecd71b 100644
> > --- a/include/linux/proc_fs.h
> > +++ b/include/linux/proc_fs.h
> > @@ -27,6 +27,17 @@ struct proc_ops {
> > unsigned long (*proc_get_unmapped_area)(struct file *, unsigned long, unsigned long, unsigned long, unsigned long);
> > };
> >
> > +struct proc_fs_info {
> > + struct pid_namespace *pid_ns;
> > + struct dentry *proc_self; /* For /proc/self */
> > + struct dentry *proc_thread_self; /* For /proc/thread-self */
> > +};
>
> Minor nit.
>
> I have not seen a patch where you remove proc_self and proc_thread_self
> from struct pid_namepace.
>
> Ideally it would have been in this patch. But as it won't break
> anyone's bisection can you please have a follow up patch that removes
> those fields?

Yep. I miss that. I will make v11 to address this and other nits.

--
Rgrds, legion