From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Oscar Carter <oscar.carter@gmx.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between previous defines
Date: Mon, 30 Mar 2020 14:27:14 +0200 [thread overview]
Message-ID: <20200330122714.GA113453@kroah.com> (raw)
In-Reply-To: <20200327165802.8445-1-oscar.carter@gmx.com>
On Fri, Mar 27, 2020 at 05:58:02PM +0100, Oscar Carter wrote:
> Define the EnCFG_BBType_MASK bit as an OR operation between two previous
> defines instead of using the OR between two new BIT macros. Thus, the
> code is more clear.
>
> Fixes: a74081b44291 ("staging: vt6656: Use BIT() macro instead of hex value")
> Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/staging/vt6656/mac.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/mac.h b/drivers/staging/vt6656/mac.h
> index c532b27de37f..b01d9ee8677e 100644
> --- a/drivers/staging/vt6656/mac.h
> +++ b/drivers/staging/vt6656/mac.h
> @@ -177,7 +177,7 @@
> #define EnCFG_BBType_a 0x00
> #define EnCFG_BBType_b BIT(0)
> #define EnCFG_BBType_g BIT(1)
> -#define EnCFG_BBType_MASK (BIT(0) | BIT(1))
> +#define EnCFG_BBType_MASK (EnCFG_BBType_b | EnCFG_BBType_g)
This does not "fix" anything, like your "Fixes:" tag implies. It just
cleans up the code some more. Only use Fixes: if it actually fixes a
problem introduced by a previous patch.
Can you remove that line and resend?
thanks.
greg k-h
next prev parent reply other threads:[~2020-03-30 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 16:58 [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between previous defines Oscar Carter
2020-03-30 11:46 ` Quentin Deslandes
2020-03-30 12:27 ` Greg Kroah-Hartman [this message]
2020-04-01 15:52 ` Oscar Carter
2020-03-31 10:29 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330122714.GA113453@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=oscar.carter@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox