From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8173C43331 for ; Mon, 30 Mar 2020 14:16:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A92DD20780 for ; Mon, 30 Mar 2020 14:16:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="t54WtOGs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728769AbgC3OQC (ORCPT ); Mon, 30 Mar 2020 10:16:02 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:37871 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727359AbgC3OQC (ORCPT ); Mon, 30 Mar 2020 10:16:02 -0400 Received: by mail-wr1-f65.google.com with SMTP id w10so21900963wrm.4; Mon, 30 Mar 2020 07:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=x+8Uj9b/3JpyVdRDH/R//D7u0C6UtUrAY1uSKsRQ9zE=; b=t54WtOGsxkvO32SeerS0tBpmoyY/Gk0fOgAJ8Mwk/dXjs1jx+DdmU44Uxbp5yr5Jsl rl6SqjDk/Ww9PGwtsPd9ofND93okQcYp1bDHcnGiwvqsSIQXvDAdTg0AAwvJ8ewBgaah 6c3J5CZ9vrwIxihgErHrQodue0QsghAMe3Mh7/k+x55F18jAAkbpflKHaZHxVNBq6oGI cRWAb0/dMD4X/G8hU4jpxm8jGvXinAoOBQ5kT7m+Sp105pHnaKTkTQuB958fN4/9Oi6R 8NJWdFF2P9/Lfiw8Q2X8VvbKo0efBgnmcIRymtXw3FETi0CG5JVd4gcPoUeGpvXKUWLf 2zvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=x+8Uj9b/3JpyVdRDH/R//D7u0C6UtUrAY1uSKsRQ9zE=; b=LBIBI0ZA166Le5exHZJZi/sJSnj4Ec2CybBqC/SqOfxQuxHrrnHro37lxj5h13oUZc W34/FrghmSTrJTdCMDJo+nqb+5e++GYXnSBliLO/P5nGVGaNr0Fk13wkJfYV1DSQq6Qq o+Kj3cqVeppFLGkApLKVPQdCciewpzDovRjOk88mSM7E6FCfk0VcxR3fLyrQa+ehO600 H33XikwD6IFoUT0l6RWuJ/MyHGf3/e+5P2bnzAWqHP4Q5EGFVveD9L0dEviJNUPa1ByD gCDGxxIP4i4W3pzZ4Z39w9/AoHw++G77b7gx7bUOFcAtvHE3KOyga7y6jBLoS+ZQDScE m7FA== X-Gm-Message-State: ANhLgQ2f0raE0dLcM/hg/zjwRgRUufUuWK5zW7F56x9GRXTUjvg2E/5h aogqBXHWOpKgOxuhJTMC3GIR44/j X-Google-Smtp-Source: ADFU+vtgriQEK814h9Q+lram7pClR6qI6cTqtJ0viMKylbDg3CAmVf9tqZYIV5ky5wiGQp2MkLO2lA== X-Received: by 2002:a5d:6a43:: with SMTP id t3mr14531633wrw.87.1585577760852; Mon, 30 Mar 2020 07:16:00 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a73sm21067244wme.47.2020.03.30.07.15.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Mar 2020 07:15:58 -0700 (PDT) Date: Mon, 30 Mar 2020 14:15:58 +0000 From: Wei Yang To: Matthew Wilcox Cc: Wei Yang , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/9] XArray: entry in last level is not expected to be a node Message-ID: <20200330141558.soeqhstone2liqud@master> Reply-To: Wei Yang References: <20200330123643.17120-1-richard.weiyang@gmail.com> <20200330123643.17120-6-richard.weiyang@gmail.com> <20200330124842.GY22483@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200330124842.GY22483@bombadil.infradead.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2020 at 05:48:42AM -0700, Matthew Wilcox wrote: >On Mon, Mar 30, 2020 at 12:36:39PM +0000, Wei Yang wrote: >> If an entry is at the last level, whose parent's shift is 0, it is not >> expected to be a node. We can just leverage the xa_is_node() check to >> break the loop instead of check shift additionally. > >I know you didn't run the test suite after making this change. I did kernel build test, but not the test suite as you mentioned. Would you mind sharing some steps on using the test suite? And which case you think would trigger the problem? -- Wei Yang Help you, Help me