Re: [PATCH v2 1/4] dt-bindings: Add Broadcom STB USB support

Rob Herring
2020-03-30T15:40:11Z

On Fri, 27 Mar 2020 16:47:08 -0400, Al Cooper wrote:
> Add DT bindings for Broadcom STB USB EHCI and XHCI drivers.
>
> NOTE: The OHCI driver is not included because it uses the generic
> platform driver.
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
> ---
> .../bindings/usb/brcm,bcm7445-ehci.yaml | 61 +++++++++++++++++++
> .../devicetree/bindings/usb/usb-xhci.txt | 1 +
> 2 files changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
>

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.example.dt.yaml: ehci@f0b00300: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.example.dt.yaml: ehci@f0b00300: $nodename:0: 'ehci@f0b00300' does not match '^usb(@.*)?'

See https://patchwork.ozlabs.org/patch/1263005

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.