From: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: "John B. Wyatt IV" <jbwyatt4@gmail.com>,
outreachy-kernel@googlegroups.com,
Julia Lawall <julia.lawall@inria.fr>,
Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Colin Ian King <colin.king@canonical.com>,
Malcolm Priestley <tvboxspy@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8] staging: vt6656: add error code handling to unused variable
Date: Tue, 31 Mar 2020 09:29:52 +0100 [thread overview]
Message-ID: <20200331082952.GA13403@jiffies> (raw)
In-Reply-To: <20200331020103.13008f53@elisabeth>
On 03/31/20 02:01:03, Stefano Brivio wrote:
> On Mon, 30 Mar 2020 16:39:00 -0700
> "John B. Wyatt IV" <jbwyatt4@gmail.com> wrote:
>
> > Add error code handling to unused 'ret' variable that was never used.
> > Return an error code from functions called within vnt_radio_power_on.
> >
> > Issue reported by coccinelle (coccicheck).
> >
> > Suggested-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
> > Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> > Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
> ^ This should be dropped unless Quentin agrees to this version as well
>
> > Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
>
> --
> Stefano
>
Just reviewed it so John doesn't need to send a v9. Everything seems
good, I'm happy and checkpatch is too.
Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
Thanks,
Quentin
prev parent reply other threads:[~2020-03-31 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 23:39 [PATCH v8] staging: vt6656: add error code handling to unused variable John B. Wyatt IV
2020-03-31 0:01 ` Stefano Brivio
2020-03-31 8:29 ` Quentin Deslandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331082952.GA13403@jiffies \
--to=quentin.deslandes@itdev.co.uk \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=jbwyatt4@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sbrivio@redhat.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox