From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4542C43331 for ; Tue, 31 Mar 2020 10:41:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACF2020772 for ; Tue, 31 Mar 2020 10:41:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="DlIr6JEf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730261AbgCaKlw (ORCPT ); Tue, 31 Mar 2020 06:41:52 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:41608 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729925AbgCaKlw (ORCPT ); Tue, 31 Mar 2020 06:41:52 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02VAfg2U102853; Tue, 31 Mar 2020 10:41:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=NObmnK1iNc485uqyg9CPnPUrBG5VCXB5zLiIIyBgYsA=; b=DlIr6JEffi+S/c2+Sz5MPf2rZdEO1SL9sqQ7AN36TxM3Pz2d+dabhi4VhToYQWfXG+ic FeO8ZXkhYTfcMUPj06Ilck2cUk+xx/gSnyNVQj5LV/QaiiIOp726JhFmyH1UY5ieYpiY ZIOjkqoupn2AhC6xUOyMWLrxQQOPXcNEg1DGkxbWE707KgURLiwPNeWLZK2kULZGK5pJ 13IaXVuSZ+hl+eFltdNKNIlzOsNGtd4oZV7iGQrfWEf3CQx7Z65Hc47YBq5cIMiQ23lg ZzxZA3ns86YFcyBL0n/Rg8EVkdo/qoF+RMJOjFm6+3Ehpk4ANuTT46+vNhf0LuorDa97 0Q== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 303aqhfa8m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Mar 2020 10:41:42 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02VAbBL5106348; Tue, 31 Mar 2020 10:41:41 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 302gcc74v0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Mar 2020 10:41:41 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02VAfcLZ016944; Tue, 31 Mar 2020 10:41:38 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 31 Mar 2020 03:41:37 -0700 Date: Tue, 31 Mar 2020 13:41:30 +0300 From: Dan Carpenter To: Oscar Carter Cc: Forest Bond , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Malcolm Priestley , linux-kernel@vger.kernel.org, Gabriela Bittencourt , Colin Ian King Subject: Re: [PATCH] staging: vt6656: Use BIT() macro in vnt_mac_reg_bits_* functions Message-ID: <20200331104130.GC2066@kadam> References: <20200320181326.12156-1-oscar.carter@gmx.com> <20200323073214.GJ4650@kadam> <20200326171043.GB3629@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200326171043.GB3629@ubuntu> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9576 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 malwarescore=0 mlxlogscore=828 adultscore=0 suspectscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003310096 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9576 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 mlxlogscore=905 spamscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003310096 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2020 at 06:10:43PM +0100, Oscar Carter wrote: > I will make these changes and i will send and incremental patch with the > "Fixes:" tag due to the this patch has already been added to the staging-next > branch of the greg staging tree. Fixes is only for bug fixes, not style issues. regards, dan carpenter