Re: [PATCH 2/2] of: some unittest overlays not untracked

Rob Herring
2020-03-31T21:58:06Z

On Wed, 25 Mar 2020 20:45:31 -0500, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> kernel test robot reported "WARNING: held lock freed!" triggered by
> unittest_gpio_remove(), which should not have been called because
> the related gpio overlay was not tracked. Another overlay that
> was tracked had previously used the same id as the gpio overlay
> but had not been untracked when the overlay was removed. Thus the
> clean up function of_unittest_destroy_tracked_overlays() incorrectly
> attempted to remove the reused overlay id.
>
> Patch contents:
>
> - Create tracking related helper functions
> - Change BUG() to WARN_ON() for overlay id related issues
> - Add some additional error checking for valid overlay id values
> - Add the missing overlay untrack
> - update comment on expectation that overlay ids are assigned in
> sequence
>
> Fixes: 492a22aceb75 ("of: unittest: overlay: Keep track of created overlays")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> drivers/of/unittest.c | 30 +++++++++++++++++++++++-------
> 1 file changed, 23 insertions(+), 7 deletions(-)
>

Applied, thanks.

Rob