Re: [PATCH V5 05/13] perf/x86: Add perf text poke events for kprobes

Peter Zijlstra
2020-04-01T10:13:47Z

On Fri, Mar 27, 2020 at 10:36:09AM +0200, Adrian Hunter wrote:
> Add perf text poke events for kprobes. That includes:
>
> - the replaced instruction(s) which are executed out-of-line
> i.e. arch_copy_kprobe() and arch_remove_kprobe()
>
> - optimised kprobe function
> i.e. arch_prepare_optimized_kprobe() and
> __arch_remove_optimized_kprobe()
>
> - optimised kprobe
> i.e. arch_optimize_kprobes() and arch_unoptimize_kprobe()
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

Looks good, but we had these nice graphs illustrating how the various
events connect, I'm thinking that would be nice to have in the
Changelog, perhaps even in a document somewhere.

These are after all 8 events here that all interplay.