From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70880C43331 for ; Wed, 1 Apr 2020 15:13:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2EC332082F for ; Wed, 1 Apr 2020 15:13:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585754009; bh=hyQu1ctMKE8nmrawXsixMKYHfW2cZqRZg1Gi0Y8mBME=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XYASxf2DjUDBjlbVjECX5etyrepp+VOwNZZcLriS3UBUdwl5bgKHOReEYZWn2DJWh uYozhgPfPnSE+WkQ+3Y0WbWT0BOtnJ5WAXG2+NElnrgkuERECKv7uEMkFNOsjU2Zl6 qmrIYzdgPqbD/4WwW3x7DKeB7/NLOHq6MsCaMfGs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732652AbgDAPN2 (ORCPT ); Wed, 1 Apr 2020 11:13:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:52418 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732442AbgDAPN1 (ORCPT ); Wed, 1 Apr 2020 11:13:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 662E420776; Wed, 1 Apr 2020 15:13:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585754007; bh=hyQu1ctMKE8nmrawXsixMKYHfW2cZqRZg1Gi0Y8mBME=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZkZKt07pTmVTmM0RhAgh++/6UyLFYe3vAvL1BBE/XFMYUBOyV/O+W6D3vzbCg0ymW r+ooAhYcElfc5EAf6QDgwWy0V2SiJODiOZs9ZTd7WiQLTbqYxsyD4huPJt2kxAAYec X6vRBHCQgkR0d68I4dLKceMJITmjwfRgXF+/nNUw= Date: Wed, 1 Apr 2020 17:12:22 +0200 From: Greg Kroah-Hartman To: Dmitry Safonov Cc: linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, "kernelci.org bot" , Michael Ellerman , Jiri Slaby Subject: Re: [PATCH] tty/sysrq: Export sysrq_mask() Message-ID: <20200401151222.GA2508664@kroah.com> References: <20200401143904.423450-1-dima@arista.com> <20200401144610.GA2433317@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 01, 2020 at 03:49:56PM +0100, Dmitry Safonov wrote: > On 4/1/20 3:46 PM, Greg Kroah-Hartman wrote: > > On Wed, Apr 01, 2020 at 03:39:04PM +0100, Dmitry Safonov wrote: > >> Build fix for serial_core being module: > >> ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined! > >> > >> Cc: Greg Kroah-Hartman > >> Cc: Jiri Slaby > >> Reported-by: "kernelci.org bot" > >> Reported-by: Michael Ellerman > >> Signed-off-by: Dmitry Safonov > >> --- > >> drivers/tty/sysrq.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > Is this a new problem? What commit does this fix? > > Right, sorry I've managed to forget adding the tag: > > Fixes: eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy") > > Maybe also: > > Link: > https://lore.kernel.org/linux-fsdevel/87tv23tmy1.fsf@mpe.ellerman.id.au/ Thanks, that works. WIll queue this up after -rc1 is out. greg k-h