From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Miroslav Benes <mbenes@suse.cz>,
Julien Thierry <jthierry@redhat.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Dmitry Golovin <dima@golovin.in>,
Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PATCH 3/5] objtool: Support Clang non-section symbols in ORC generation
Date: Wed, 1 Apr 2020 14:08:55 -0500 [thread overview]
Message-ID: <20200401190855.yvk4lc3ijaexoxal@treble> (raw)
In-Reply-To: <20200401190548.rodiauk3iolknvfe@treble>
On Wed, Apr 01, 2020 at 02:05:51PM -0500, Josh Poimboeuf wrote:
> On Wed, Apr 01, 2020 at 08:49:53PM +0200, Peter Zijlstra wrote:
> > On Wed, Apr 01, 2020 at 01:23:27PM -0500, Josh Poimboeuf wrote:
> >
> > > @@ -105,8 +100,32 @@ static int create_orc_entry(struct elf *elf, struct section *u_sec, struct secti
> > > }
> > > memset(rela, 0, sizeof(*rela));
> > >
> > > - rela->sym = insn_sec->sym;
> > > - rela->addend = insn_off;
> > > + if (insn_sec->sym) {
> > > + rela->sym = insn_sec->sym;
> > > + rela->addend = insn_off;
> > > + } else {
> > > + /*
> > > + * The Clang assembler doesn't produce section symbols, so we
> > > + * have to reference the function symbol instead:
> > > + */
> > > + rela->sym = find_symbol_containing(insn_sec, insn_off);
> >
> > It's a good thing I made that a lot faster I suppose ;-)
>
> :-)
>
> > > + if (!rela->sym) {
> > > + /*
> > > + * Hack alert. This happens when we need to reference
> > > + * the NOP pad insn immediately after the function.
> > > + */
> > > + rela->sym = find_symbol_containing(insn_sec,
> > > + insn_off - 1);
> >
> > Urgh, when does that happen?
>
> It happens naturally in the padding between functions, since objtool
> doesn't traverse those instructions. So they have undefined entries
> like
>
> .text+68: sp:(und) bp:(und) type:call end:0
>
> I suppose those aren't technically necessary.
In fact, we could probably get substantial savings in the ORC table if
we skipped those, i.e.
.text+0: sp:sp+8 bp:(und) type:call end:0
.text+8: sp:(und) bp:(und) type:call end:0
.text+10: sp:sp+8 bp:(und) type:call end:0
.text+17: sp:sp+16 bp:(und) type:call end:0
.text+18: sp:sp+24 bp:prevsp-24 type:call end:0
.text+1c: sp:sp+32 bp:prevsp-24 type:call end:0
.text+5a: sp:sp+24 bp:prevsp-24 type:call end:0
.text+61: sp:sp+16 bp:(und) type:call end:0
.text+63: sp:sp+8 bp:(und) type:call end:0
.text+68: sp:(und) bp:(und) type:call end:0
.text+70: sp:sp+8 bp:(und) type:call end:0
.text+8c: sp:(und) bp:(und) type:call end:0
.text+90: sp:sp+8 bp:(und) type:call end:0
.text+cd: sp:(und) bp:(und) type:call end:0
.text+d0: sp:sp+8 bp:(und) type:call end:0
would be compressed to
.text+0: sp:sp+8 bp:(und) type:call end:0
.text+17: sp:sp+16 bp:(und) type:call end:0
.text+18: sp:sp+24 bp:prevsp-24 type:call end:0
.text+1c: sp:sp+32 bp:prevsp-24 type:call end:0
.text+5a: sp:sp+24 bp:prevsp-24 type:call end:0
.text+61: sp:sp+16 bp:(und) type:call end:0
.text+63: sp:sp+8 bp:(und) type:call end:0
but I can do that in a separate patch, and if it works I can remove this
hack.
--
Josh
next prev parent reply other threads:[~2020-04-01 19:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 18:23 [PATCH 0/5] objtool fixes Josh Poimboeuf
2020-04-01 18:23 ` [PATCH 1/5] objtool: Fix CONFIG_UBSAN_TRAP unreachable warnings Josh Poimboeuf
2020-04-02 7:30 ` Kees Cook
2020-04-14 10:34 ` [tip: x86/urgent] " tip-bot2 for Josh Poimboeuf
2020-04-01 18:23 ` [PATCH 2/5] objtool: Support Clang non-section symbols in ORC dump Josh Poimboeuf
2020-04-14 10:34 ` [tip: x86/urgent] " tip-bot2 for Josh Poimboeuf
2020-04-01 18:23 ` [PATCH 3/5] objtool: Support Clang non-section symbols in ORC generation Josh Poimboeuf
2020-04-01 18:49 ` Peter Zijlstra
2020-04-01 19:05 ` Josh Poimboeuf
2020-04-01 19:08 ` Josh Poimboeuf [this message]
2020-04-03 8:58 ` Miroslav Benes
2020-04-03 14:58 ` Josh Poimboeuf
2020-04-14 10:34 ` [tip: x86/urgent] " tip-bot2 for Josh Poimboeuf
2020-04-01 18:23 ` [PATCH 4/5] objtool: Fix switch table detection in .text.unlikely Josh Poimboeuf
2020-04-14 10:34 ` [tip: x86/urgent] " tip-bot2 for Josh Poimboeuf
2020-04-01 18:23 ` [PATCH 5/5] objtool: Make BP scratch register warning more robust Josh Poimboeuf
2020-04-14 10:34 ` [tip: x86/urgent] " tip-bot2 for Josh Poimboeuf
2020-04-02 14:28 ` [PATCH 0/5] objtool fixes Peter Zijlstra
2020-04-03 9:00 ` Miroslav Benes
2020-04-09 13:53 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401190855.yvk4lc3ijaexoxal@treble \
--to=jpoimboe@redhat.com \
--cc=dima@golovin.in \
--cc=jthierry@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox