From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2CE0C2BA12 for ; Thu, 2 Apr 2020 06:45:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99A1E20784 for ; Thu, 2 Apr 2020 06:45:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KNE5T8qn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387463AbgDBGp5 (ORCPT ); Thu, 2 Apr 2020 02:45:57 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:42930 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728425AbgDBGp5 (ORCPT ); Thu, 2 Apr 2020 02:45:57 -0400 Received: by mail-pf1-f195.google.com with SMTP id 22so1296746pfa.9 for ; Wed, 01 Apr 2020 23:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QnW1FRwTH4xbg6LjM8uAuRTxGm5LQR9zZzf7WroNXlk=; b=KNE5T8qnOrg8DU2Uf0oSMAWQslv7RAp37B4JyeQ3UXi+xSSIhp/xde1qIF/pvqxL9J uxZGuNG4rugzfgwvQE8KO6Q9zN4Gn2dem01V61dEZ4+yTTmhAUzhQuxb4qetrbd2QzQ9 VZ/5M5Ai8cumWOzOutq4YrufW5MGwo0BkntamiaU4X7bIamT+y67fMt8yADlN9TylaUH K8F9HomtVYyoxklKUgsWeuDhjNcxaJbb5dhX4UFj73+0sZW+WkOrdQTHhP3RSnke6AVV 0GUCdQa0Egz+xressXuZyWEB+f5tjVbuymp2GuRRrw4Q0lliCdINuQjSevox+BOjLR+G QQCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QnW1FRwTH4xbg6LjM8uAuRTxGm5LQR9zZzf7WroNXlk=; b=sIquo30pAHoPLXnTo2mkaA8Sg5K+FZawcyOuKkkPzcLNuS5Qzn+Zqu8A9fw1axTG31 e/b5Dz5DpXHestHdqJQBkCkdoWn8agDF+YHt06oaGq1iYc9BHuSwdw6I+fwslvrzhO+9 P//gR1XVk+0JVE1tE1p+eTJXGSrPDaf9NjaJ5dAEPwjXqlA9ZY+gpVqWj7EkdPhyxsYn 3gaL/K5e/vKoeNMsot3VwyfHt9BB7thF58RB8n8SEZvtU8Iv1QpTV3RZ8QM3OTE6+iT2 i8K5o2OYau5iPRgRSZjM1BkvcDens4U9YlPwhx0drgM7fx+E1Y3XeoZczFiVN7waq8yz AHlQ== X-Gm-Message-State: AGi0PuaZWt5Hcsfj0qqoTfWjU1Vhp8vGulRa+ZfI3Lx2Om/x/QMDyej3 Gq6btzZeS/IbONsC+dUPLQ2SnhB08eE= X-Google-Smtp-Source: APiQypLGCELqQ+CVBf3q8b/1bk+rBZgF5Fqa4XWZ5iwiVgkfN8O0vF2RVSrCHg3HEEPGfX83+uu63Q== X-Received: by 2002:a62:cdcc:: with SMTP id o195mr1696130pfg.323.1585809955390; Wed, 01 Apr 2020 23:45:55 -0700 (PDT) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id ck3sm3006406pjb.44.2020.04.01.23.45.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 23:45:54 -0700 (PDT) Date: Wed, 1 Apr 2020 23:45:52 -0700 From: Bjorn Andersson To: Tang Bin Cc: agross@kernel.org, robdclark@gmail.com, joro@8bytes.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/qcom:fix local_base status check Message-ID: <20200402064552.GG663905@yoga> References: <20200402063302.20640-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200402063302.20640-1-tangbin@cmss.chinamobile.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 01 Apr 23:33 PDT 2020, Tang Bin wrote: > Release resources when exiting on error. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Tang Bin > --- > drivers/iommu/qcom_iommu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c > index 4328da0b0..c08aa9651 100644 > --- a/drivers/iommu/qcom_iommu.c > +++ b/drivers/iommu/qcom_iommu.c > @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct platform_device *pdev) > qcom_iommu->dev = dev; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (res) > + if (res) { > qcom_iommu->local_base = devm_ioremap_resource(dev, res); > + if (IS_ERR(qcom_iommu->local_base)) > + return PTR_ERR(qcom_iommu->local_base); > + } > > qcom_iommu->iface_clk = devm_clk_get(dev, "iface"); > if (IS_ERR(qcom_iommu->iface_clk)) { > -- > 2.20.1.windows.1 > > >