From: Christoph Hellwig <hch@lst.de>
To: Philippe Liard <pliard@google.com>
Cc: Christoph Hellwig <hch@lst.de>,
phillip@squashfs.org.uk, linux-kernel@vger.kernel.org,
groeck@chromium.org
Subject: Re: [PATCH v3] squashfs: Migrate from ll_rw_block usage to BIO
Date: Thu, 2 Apr 2020 17:35:06 +0200 [thread overview]
Message-ID: <20200402153506.GA13332@lst.de> (raw)
In-Reply-To: <CAEThQxeC2qyUr+3EO7o+2p5tziXQ621SqaaxmF3jzheCKjpEkA@mail.gmail.com>
On Fri, Nov 15, 2019 at 10:20:33AM +0900, Philippe Liard wrote:
> On Wed, Nov 6, 2019 at 6:28 PM Philippe Liard <pliard@google.com> wrote:
> >
> > On Wed, Nov 6, 2019 at 5:37 PM Christoph Hellwig <hch@lst.de> wrote:
> > >
> > > Sorry for the empty reply.
> > >
> > > This was meant to say that the patch looks good to me:
> > >
> > > Reviewed-by: Christoph Hellwig <hch@lst.de>
> >
> > Thanks!
>
> FYI I'm unfortunately no longer observing the 40% impact announced in the
> commit description after many optimizations landed in the Chrome OS VM
> infrastructure.
>
> Hopefully moving to BIO is still desirable though. Thank you in any case for
> your help/guidance and all the time you spent reviewing this.
Do you still plan to submit the patch? I think it is a major cleanup
of the codebase, so I'd like to see it land.
next prev parent reply other threads:[~2020-04-02 15:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 7:42 [PATCH v3] squashfs: Migrate from ll_rw_block usage to BIO Philippe Liard
2019-11-06 8:34 ` Christoph Hellwig
2019-11-06 8:37 ` Christoph Hellwig
2019-11-06 9:28 ` Philippe Liard
2019-11-15 1:20 ` Philippe Liard
2020-04-02 15:35 ` Christoph Hellwig [this message]
2020-04-03 1:37 ` Philippe Liard
2020-04-08 6:24 ` Christoph Hellwig
2020-04-09 0:38 ` Andrew Morton
2020-04-09 15:55 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402153506.GA13332@lst.de \
--to=hch@lst.de \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@squashfs.org.uk \
--cc=pliard@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox