From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=iZC5=5S=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 85C1CC43331
	for <linux-kernel@archiver.kernel.org>; Thu,  2 Apr 2020 15:35:11 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 63C3520737
	for <linux-kernel@archiver.kernel.org>; Thu,  2 Apr 2020 15:35:11 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2389326AbgDBPfK (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 2 Apr 2020 11:35:10 -0400
Received: from verein.lst.de ([213.95.11.211]:48940 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1732754AbgDBPfK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Apr 2020 11:35:10 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id F09D668B05; Thu,  2 Apr 2020 17:35:06 +0200 (CEST)
Date:   Thu, 2 Apr 2020 17:35:06 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Philippe Liard <pliard@google.com>
Cc:     Christoph Hellwig <hch@lst.de>, phillip@squashfs.org.uk,
        linux-kernel@vger.kernel.org, groeck@chromium.org
Subject: Re: [PATCH v3] squashfs: Migrate from ll_rw_block usage to BIO
Message-ID: <20200402153506.GA13332@lst.de>
References: <20191106074238.186023-1-pliard@google.com> <20191106083423.GA10679@lst.de> <20191106083711.GB10679@lst.de> <CAEThQxe2sNuCHoQfa30FVmtYkQ_zJsecdW2wmVmwafvne1RXSg@mail.gmail.com> <CAEThQxeC2qyUr+3EO7o+2p5tziXQ621SqaaxmF3jzheCKjpEkA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEThQxeC2qyUr+3EO7o+2p5tziXQ621SqaaxmF3jzheCKjpEkA@mail.gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 15, 2019 at 10:20:33AM +0900, Philippe Liard wrote:
> On Wed, Nov 6, 2019 at 6:28 PM Philippe Liard <pliard@google.com> wrote:
> >
> > On Wed, Nov 6, 2019 at 5:37 PM Christoph Hellwig <hch@lst.de> wrote:
> > >
> > > Sorry for the empty reply.
> > >
> > > This was meant to say that the patch looks good to me:
> > >
> > > Reviewed-by: Christoph Hellwig <hch@lst.de>
> >
> > Thanks!
> 
> FYI I'm unfortunately no longer observing the 40% impact announced in the
> commit description after many optimizations landed in the Chrome OS VM
> infrastructure.
> 
> Hopefully moving to BIO is still desirable though. Thank you in any case for
> your help/guidance and all the time you spent reviewing this.

Do you still plan to submit the patch?  I think it is a major cleanup
of the codebase, so I'd like to see it land.