From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03C9EC43331 for ; Thu, 2 Apr 2020 15:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2BD820757 for ; Thu, 2 Apr 2020 15:58:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="otzYCRNx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389604AbgDBP6Q (ORCPT ); Thu, 2 Apr 2020 11:58:16 -0400 Received: from mail.skyhub.de ([5.9.137.197]:42518 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389318AbgDBP6P (ORCPT ); Thu, 2 Apr 2020 11:58:15 -0400 Received: from zn.tnic (p200300EC2F0A0E00E5DA45869CAED91E.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:e00:e5da:4586:9cae:d91e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 525451EC0469; Thu, 2 Apr 2020 17:58:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1585843094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KN71Axi3R2DOnnEsCnv9ks/tbfgC0G4SVUAhgahUx30=; b=otzYCRNxzjG3bT5gHzs421cwgrbkrbyBFIs+WVi8Zd5uA9EZuHNh9AT7nyW/NqiI7y2akZ VAfqjkZdx1gBj/wVPL4UKMkbmiBf5Y2u+HOrx9bwHAxiwiJACS0cXKW0/oiHb+c3dROiBK 3aWKW7D3xW+VVbzVKAdAkj2UTZy/wSc= Date: Thu, 2 Apr 2020 17:58:10 +0200 From: Borislav Petkov To: Nick Terrell Cc: Nick Terrell , "linux-kernel@vger.kernel.org" , Chris Mason , "linux-kbuild@vger.kernel.org" , "x86@kernel.org" , "gregkh@linuxfoundation.org" , Petr Malat , Kees Cook , Kernel Team , Adam Borowski , Patrick Williams , Michael van der Westhuizen , "mingo@kernel.org" , Patrick Williams , Sedat Dilek Subject: Re: [PATCH v4 6/8] x86: bump ZO_z_extra_bytes margin for zstd Message-ID: <20200402155810.GD9352@zn.tnic> References: <20200401053913.216783-1-nickrterrell@gmail.com> <20200401053913.216783-7-nickrterrell@gmail.com> <20200401093310.GA13748@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 01, 2020 at 05:33:03PM +0000, Nick Terrell wrote: > The code is currently written so that all the compression algorithms use the > same ZO_z_extra_bytes. It is taken to be the maximum of the growth rate > plus the maximum fixed overhead. Just a few lines above is the comment: > > # … Hence safety > # margin should be updated to cover all decompressors so that we don't > # need to deal with each of them separately. Please check > # the description in lib/decompressor_xxx.c for specific information. > > So I was been following the guidance in the comments. Please state that in the commit message when you send your next revision. > Does it matter? I’m not an expert here, Huh, you're only sending the code then? Or what do you mean with not being an expert? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette