Re: [PATCH v2 01/10] objtool: Move header sync-check ealier in build

Miroslav Benes
2020-04-01T12:55:17Z

On Wed, 1 Apr 2020, Julien Thierry wrote:

>
>
> On 4/1/20 1:32 PM, Miroslav Benes wrote:
> > On Fri, 27 Mar 2020, Julien Thierry wrote:
> >
> >> Currently, the check of tools files against kernel equivalent is only
> >> done after every object file has been built.
> >
> >> This means one might fix
> >> build issues against outdated headers without seeing a warning about
> >> this.
> >
> > Could you explain the above in more detail, please?
> >
>
> I must admit that this patch is more fixing the issues I've faced while
> working on the arm64 support and sharing some kernel headers from the
> arch/arm64 tree.
>
> The annoying part was:
> - Have build errors in objtool
> - Fix them
> - Objtool build succeeds, but have warning about outdated headers
> - Update headers
> - New errors come up, potentially making obsolete the ealier fixes

Ah right, yes.

> So it's not really a "must have" change. But it's nice to have when bringing
> new kernel headers to objtool.

No, I think it is useful.

> I hope this makes things clearer.

Yes, it does.

Thanks
Miroslav