Re: [PATCH v2 10/10] objtool: Support multiple stack_op per instruction

Peter Zijlstra
2020-04-02T18:25:58Z

On Thu, Apr 02, 2020 at 12:54:26PM -0500, Josh Poimboeuf wrote:
> On Fri, Mar 27, 2020 at 03:28:47PM +0000, Julien Thierry wrote:
> > @@ -127,6 +129,10 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
> > if (insn.sib.nbytes)
> > sib = insn.sib.bytes[0];
> >
> > + op = calloc(1, sizeof(*op));
> > + if (!op)
> > + return -1;
> > +
>
> Why not malloc()?

calloc() does a memset(), I wondered the same and read the manpage ;-)