Re: [PATCH v2 11/16] gpio: add support for the sl28cpld GPIO controller

Michael Walle
2020-04-16T08:59:21Z

Hi Linus,

Am 2020-04-16 10:34, schrieb Linus Walleij:
> Hi Michael,
>
> this is looking good provided we can get the generic GPIO regmap
> helper reviewed and merged. Thanks!
>
> On Thu, Apr 2, 2020 at 10:37 PM Michael Walle <michael@walle.cc> wrote:
>
>> This adds support for the GPIO controller of the sl28 board management
>> controller. This driver is part of a multi-function device.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>
>> + depends on MFD_SL28CPLD
>
> Apart from this depends it seems the patch is compile-time
> independent of the other patches

correct. There are no common mfd headers or something like that.

> so I'd suggest we just merge
> the generic regmap driver and this driver to the GPIO tree once
> we feel finished with them, optimistically assuming that the MFD
> driver will land and that we will not need any fundamental
> changes in the GPIO driver.
>
> Worst case we have to revert the driver and that is no disaster.

Sure. One major thing I'm waiting for is the decision/new ideas on
how to handle the "register is not set or zero" problem, see the
other thread on the generic regmap gpio. Then I'd respin an update
of this whole series.

-michael