From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF0E0C43331 for ; Thu, 2 Apr 2020 21:27:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A821820737 for ; Thu, 2 Apr 2020 21:27:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="L+fpB+ex" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388801AbgDBV1a (ORCPT ); Thu, 2 Apr 2020 17:27:30 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:26179 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729549AbgDBV1a (ORCPT ); Thu, 2 Apr 2020 17:27:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585862848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nYosSnECcnDnXEwCUr/zQ5HjFFOmJvXZ42i/XsVNG9w=; b=L+fpB+ex4AL4w85vyAzQJQwnxhOf6N7iLnOuSLZqqAkCEk8GxKRj8dECximrAImedF+vPR jM+vJMPTt0DENO8Fq3av3trWzmy7vH+XCstmqTfSS6h987vwPo1QQhe7UD0IByhiagnbcc o/xYM+o7vJrtj3+Rs36LNu0gTulXzgw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-pomMgmzbOCyAw40CTZu6UA-1; Thu, 02 Apr 2020 17:27:25 -0400 X-MC-Unique: pomMgmzbOCyAw40CTZu6UA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 442CD8017F5; Thu, 2 Apr 2020 21:27:22 +0000 (UTC) Received: from krava (unknown [10.40.194.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 26AF2196AE; Thu, 2 Apr 2020 21:27:08 +0000 (UTC) Date: Thu, 2 Apr 2020 23:27:04 +0200 From: Jiri Olsa To: Kajol Jain Cc: acme@kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, sukadev@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, anju@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com, ravi.bangoria@linux.ibm.com, peterz@infradead.org, yao.jin@linux.intel.com, ak@linux.intel.com, jolsa@kernel.org, kan.liang@linux.intel.com, jmario@redhat.com, alexander.shishkin@linux.intel.com, mingo@kernel.org, paulus@ozlabs.org, namhyung@kernel.org, mpetlan@redhat.com, gregkh@linuxfoundation.org, benh@kernel.crashing.org, mamatha4@linux.vnet.ibm.com, mark.rutland@arm.com, tglx@linutronix.de Subject: Re: [PATCH v8 0/7] powerpc/perf: Add json file metric support for the hv_24x7 socket/chip level events Message-ID: <20200402212704.GC2784502@krava> References: <20200401203340.31402-1-kjain@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200401203340.31402-1-kjain@linux.ibm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2020 at 02:03:33AM +0530, Kajol Jain wrote: > Patchset adds json file metric support for the hv_24x7 socket/chip level > events. "hv_24x7" pmu interface events needs system dependent parameter > like socket/chip/core. For example, hv_24x7 chip level events needs > specific chip-id to which the data is requested should be added as part > of pmu events. > > So to enable JSON file support to "hv_24x7" interface, patchset reads > total number of sockets details in sysfs under > "/sys/devices/hv_24x7/interface/". > > Second patch of the patchset adds expr_scanner_ctx object to hold user > data for the expr scanner, which can be used to hold runtime parameter. > > Patch 4 & 6 of the patchset handles perf tool plumbing needed to replace > the "?" character in the metric expression to proper value and hv_24x7 > json metric file for different Socket/chip resources. > > Patch set also enable Hz/hz prinitg for --metric-only option to print > metric data for bus frequency. > > Applied and tested all these patches cleanly on top of jiri's flex changes > with the changes done by Kan Liang for "Support metric group constraint" > patchset and made required changes. > > Also apply this patch on top of the fix patch send earlier > for printing metric name incase overlapping events. > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=37cd7f65bf71a48f25eeb6d9be5dacb20d008ea6 > > Changelog: > v7 -> v8 > - Add test case for testing parsing of "?" in metric expression > - Reaname variables name to runtime Acked-by: Jiri Olsa thanks, jirka